Debug cannot read property 'onError' of undefined #61649
Assignees
Labels
Milestone
Comments
|
(Experimental duplicate detection) |
|
Did something about this API change? Also, @carlocardella could you possibly try to attach the vscode logs? I'm not 100% where they are but maybe go to: "Developer: Show logs..." and open each of those and paste it here. |
|
Extension Host is the only one with some interesting tracing: |
|
The process does not seem to crash (at least not the main process). I can collect a dump in first chance exceptions if that helps |
isidorn
added
the
debug
|
I can not reproduce this issue both on my OS X and on my windows. I am using a simple powershell hello world sample and the "PowerShell Launch Current File" config you attached. However is seeing this error please do the following:
|
|
I can consistently repro on two machines, a third one (all three should be using the same settings and extensions, I'm keeping them in sync with This is the full Developer Tools console output from a fresh session while I reproduced the error: No differences in your actions, except I did not try on OS X, just Windows |
|
@carlocardella since you can reproduce and the logs are not useful in this case Also make sure to not have any extensions installed when reproducing this bug. LIke live share |
|
If you want me to pair-debug this with you, @carlocardella, just let me know and I can stop by. 👍 |
|
The problem seems a conflict with Live Share, if I disable it then the error disappears and I can debug powershell. I can certainly try to debug more, anything specific should I look for? |
|
Please file this against a live share extension and continue the investigation there - they would know more. |
|
I can easily reproduce. The issue is that the PowerShell extension does not contribute a "label" property in its package.json but relies on its "type" property to be used as a label (which explains why the type uses a rather unusual camel case style). When running the PowerShell DA in the EH instead of VS Code, we were ignoring debugger contributions that lack the type attribute. In addition the error alert was not describing the problem adequately. /cc @rkeithhill |
|
I've fixed the bug by accepting debugger contribution that lack a "label" but have a "program" or "runtime" instead. In addition, I've improved the error reporting. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
From @carlocardella on October 23, 2018 16:35
Issue Description
Insiders only (works fine in Stable): every time I try to start a debug session (either press F5, or use the Start Debug command), regardless of the debug type I select (Interactive Sessions, or Current File etc...) I always get the error in the screenshot.
I can reproduce with all extensions disabled (except Powershell of course), I tried to clean my C:\Users\carloc.vscode-insiders\extensions folder (basically reinstall the extensions from scratch) but the problem remains.
I use Code Insiders as my primary editor, I think I got this error the first time towards the end of last week but I don't have exact dates to confirm
Attached Logs
1540311154-1018dcff-3bc2-424c-a3bf-83841bbc9be21540311145453.zip
Environment Information
Visual Studio Code
PowerShell Information
launch.json
{ // Use IntelliSense to learn about possible attributes. // Hover to view descriptions of existing attributes. // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387 "version": "0.2.0", "configurations": [{ "type": "PowerShell", "request": "launch", "name": "PowerShell Launch Current File", "script": "${file}", "args": [], "cwd": "${file}" }, { "type": "PowerShell", "request": "launch", "name": "PowerShell Launch Current File in Temporary Console", "script": "${file}", "args": [], "cwd": "${file}", "createTemporaryIntegratedConsole": true }, { "type": "PowerShell", "request": "launch", "name": "PowerShell Launch Current File w/Args Prompt", "script": "${file}", "args": [ "${command:SpecifyScriptArgs}" ], "cwd": "${file}" }, { "type": "PowerShell", "request": "attach", "name": "PowerShell Attach to Host Process", "processId": "${command:PickPSHostProcess}", "runspaceId": 1 }, { "type": "PowerShell", "request": "launch", "name": "PowerShell Interactive Session", "cwd": "" } ] }Visual Studio Code Extensions
Visual Studio Code Extensions(Click to Expand)
Copied from original issue: PowerShell/vscode-powershell#1590
The text was updated successfully, but these errors were encountered: