Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit message should use to full editor #85721

Closed
ssbarnea opened this issue Nov 27, 2019 · 1 comment
Closed

Commit message should use to full editor #85721

ssbarnea opened this issue Nov 27, 2019 · 1 comment
Assignees

Comments

@ssbarnea
Copy link

Based on StackOverflow post about editable commit message in vscode the entire commit action should be changed in order to use a full editor. This will consolidate the user experience when using git from command line and configuring vscode as preferred editor.

There is no treason to have a different editing experiences for the two cases. In fact is a bit ironic that editing the commit message is much better when git calls vscode than using vscode directly. This enables spellchecking, linting, syntax checks like 50/72 rule and a ton of other features which are not available in the crippled input box of the default commit feature.

vscode-git-commit-edit

@joaomoreno
Copy link
Member

joaomoreno commented Nov 28, 2019

There is no treason to have a different editing experiences for the two cases.

Actually there is. Most people don't really want a full editor taking away workbench space. They just want to type a message and move on.

Nevertheless, a full editor experience has its merits and can be tracked here: #30562

@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants