Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update maxversiontested so xaml islands can be used in vstest.console.exe #5041

Open
ChrisGuzak opened this issue May 15, 2024 · 3 comments
Open

Comments

@ChrisGuzak
Copy link
Member

ChrisGuzak commented May 15, 2024

Description

This is a variation of #4887 that I missed when I fix that (that I've verified via updated VS).

vstest.console.exe needs the same manifest update.

but I took a look at the source and see it has been updated. need to investigate further.

Steps to reproduce

see linked issue for repo and details

@nohwnd
Copy link
Member

nohwnd commented May 20, 2024

Would you post a PR for this please?

@ChrisGuzak
Copy link
Member Author

ChrisGuzak commented May 21, 2024

The code in this project is correct.

I'm guessing the ingestion vstest.console.exe into the VS installer is not following the same path as testhost.exe. I see the files are in different locations.

C:\Program Files\Microsoft Visual Studio\2022\Enterprise\Common7\IDE
    CommonExtensions\Microsoft\TestWindow\vstest.console.exe
    Extensions\TestPlatform\testhost.exe

I also installed these tools using the BuildTools install location and that ended up in a different location from those mentioned above (note the x86)

C:\Program Files (x86)\Microsoft Visual Studio\2022\BuildTools\Common7\IDE\CommonExtensions\Microsoft\TestWindow\vstest.console.exe

Do you know who owns the VS ingestion process for these binaries? I think we need to ask them why this binary has not kept up with testhost.exe.

@nohwnd
Copy link
Member

nohwnd commented May 21, 2024

You've got mail. CommonExtensions\Microsoft\TestWindow\vstest.console.exe is a wrapper of the real vstest.console for backwards compat reasons. It won't have your manifest changes, and so that is why it does not work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants