New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InProcessVsTestConsoleWrapper creates a VsTestConsoleProcessManager but doesn't Dispose() it #5117

Open

omajid opened this issue Jun 24, 2024 · 1 comment · May be fixed by #5126

Contributor

omajid commented Jun 24, 2024

vstest/src/vstest.console/InProcessVsTestConsoleWrapper.cs

Line 129 in 5b69fd3

    
           var args = new VsTestConsoleProcessManager(someExistingFile).BuildArguments(consoleParameters);

The VsTestConsoleProcessManager is an IDisposable, but it's never disposed in this piece of code.

Does it need to be Dispose()d or is it safe to ignore?

nohwnd linked a pull request

that will close this issue

Dispose helper when parsing args #5126

Open

Member

nohwnd commented Jul 1, 2024

It is disposable because of potentially holding process object, but in this method it does not hold it. Added using.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment