Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Ask for Bfloat16 data type insert. #36468

Open
1 task done
mellonyou opened this issue Sep 24, 2024 · 7 comments
Open
1 task done

[Feature]: Ask for Bfloat16 data type insert. #36468

mellonyou opened this issue Sep 24, 2024 · 7 comments
Assignees
Labels
kind/feature Issues related to feature request from users

Comments

@mellonyou
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe.

Have added bfloat16 support in knowhere, and query performance have a significate improve. But, directly writing bf16 data type, which need to be converted to bytes, it will results in poor performance.

Describe the solution you'd like.

Can write bfloat16 data type directly without type convert.

Describe an alternate solution.

No response

Anything else? (Additional Context)

No response

@mellonyou mellonyou added the kind/feature Issues related to feature request from users label Sep 24, 2024
@xiaofan-luan
Copy link
Contributor

which SDk are u using?
Many of the language don't have Bf16 as datatype, that's why we convert it to binary

@mellonyou
Copy link
Author

I test it with python script, and I want to use milvus to receive bf16 data from langchain.

@xiaofan-luan
Copy link
Contributor

I test it with python script, and I want to use milvus to receive bf16 data from langchain.

Did langchain support BF16 embedding already?

@zc277584121
Copy link

As far as I know, langchain itself does not involve data type processing, but generally some deep learning frameworks such as tf, pytorch can generate bf16. @mellonyou Can you please explain your scenario in detail? Are you trying to use langchain_milvus to do this?

@congqixia
Copy link
Contributor

congqixia commented Sep 24, 2024

Maybe the need is to integrate langchain output direct into milvus collection with BFloat16 field, which means the input vector is in float32 and let Milvus server do the data type conversion internally

@mellonyou
Copy link
Author

@zc277584121 Yes, I am using langchain_milvus to interact with milvus. Actually, I want to integrate milvus into RAG, for dataprep&retrievers. I am trying to setup a bf16 pipeline, the output from embedding is bf16, it need milvus can support bf16 insert&query.

@zc277584121
Copy link

@mellonyou Thank you for your feedback. We will verify the feasibility and try to add some features to meet this requirement in later versions of langchain_milvus.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Issues related to feature request from users
Projects
None yet
Development

No branches or pull requests

4 participants