-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thousands separator in badge image #559
Comments
The badges are currently generated by shields.io by making a request to a JSON API, there doesn't appear to be an option to change the formatting:
So it's likely the code will need to switch to using a static shields.io badge with the information added by the ContentDB redirect: https://github.com/minetest/contentdb/blob/master/app/blueprints/packages/packages.py#L195-L198 |
Fun fact: in Italian, we use commas as floating points and dots as thousands. So if I see a number like |
German does this too. |
Some languages like Japanese might count in blocks of four https://japanese.stackexchange.com/questions/16241/is-there-a-reason-why-numbers-in-japanese-are-delimited-into-blocks-of-four |
Problem
Badge image shows
1234546 downloads
Solutions
Badge image should show
1,234,546 downloads
because that's easier to readAdditional context
https://stackoverflow.com/questions/1823058/how-to-print-a-number-using-commas-as-thousands-separators
The text was updated successfully, but these errors were encountered: