Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore - added status check to submit claim #134

Merged
merged 5 commits into from
Nov 11, 2016

Conversation

stevenalexander
Copy link
Contributor

fixes #85

Checklist

  • Unit tests
  • End-to-End tests
  • Code coverage checked
  • Coding standards
  • Error Handling
  • Security/performance considered?
  • Deployment changes considered?
  • README updated

@@ -23,6 +23,12 @@ module.exports = function (router) {
.then(function () {
return res.redirect(`/application-submitted/${req.params.reference}`)
})
.catch(function (error) {
next(error)
})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should only need one .catch. Remove the inner catch.

There is no unit test to test for this branch being hit.

@tmrowe tmrowe merged commit 049062e into develop Nov 11, 2016
@tmrowe tmrowe deleted the chore/add-status-check-to-submit-claim branch November 11, 2016 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add check on claim status before submitting
3 participants