From 546ce467cd90d6e51de69241c282d5e84bcbf750 Mon Sep 17 00:00:00 2001
From: RhinosF1 <rhinosf1@gmail.com>
Date: Fri, 21 Jun 2024 15:00:11 +0100
Subject: [PATCH 1/2] fix logic error when using --disable

Bug: T12235
---
 maintenance/toggleExtension.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/maintenance/toggleExtension.php b/maintenance/toggleExtension.php
index 84130101e..cc58578ac 100644
--- a/maintenance/toggleExtension.php
+++ b/maintenance/toggleExtension.php
@@ -50,7 +50,7 @@ public function execute() {
 				if ( !$noList ) {
 					$this->output( "Removed $ext from $wiki" );
 				}
-			} elseif ( !in_array( $ext, $extensionList ) ) {
+			} elseif ( !(in_array( $ext, $extensionList ) ) && $disable ){
 				$mwExt->add( $ext );
 				$mwExt->commit();
 				if ( !$noList ) {

From 14788f661037b593a1cbade9892aa025a47329fb Mon Sep 17 00:00:00 2001
From: github-actions <github-actions@users.noreply.github.com>
Date: Fri, 21 Jun 2024 14:01:37 +0000
Subject: [PATCH 2/2] CI: lint code to MediaWiki standards

Check commit and GitHub actions for more details
---
 maintenance/toggleExtension.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/maintenance/toggleExtension.php b/maintenance/toggleExtension.php
index cc58578ac..11826748b 100644
--- a/maintenance/toggleExtension.php
+++ b/maintenance/toggleExtension.php
@@ -50,7 +50,7 @@ public function execute() {
 				if ( !$noList ) {
 					$this->output( "Removed $ext from $wiki" );
 				}
-			} elseif ( !(in_array( $ext, $extensionList ) ) && $disable ){
+			} elseif ( !( in_array( $ext, $extensionList ) ) && $disable ) {
 				$mwExt->add( $ext );
 				$mwExt->commit();
 				if ( !$noList ) {