Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DlgCoverArtFullSize won't close if no cover was found #11021

Closed
ronso0 opened this issue Oct 28, 2022 · 2 comments
Closed

DlgCoverArtFullSize won't close if no cover was found #11021

ronso0 opened this issue Oct 28, 2022 · 2 comments

Comments

@ronso0
Copy link
Member

ronso0 commented Oct 28, 2022

Bug Description

occurs with DlgCoverArtFullSize initialized from WCoverArtLabel in DlgTrackInfo

  • open Track Properties for a track with no cover
  • WCoverArtLabel shows default cover
  • click default cover
  • minimal DlgCoverArtFullSize with no cover is shown
  • clicking close button or inside the empyt cover area does nothing (actually it triggers DlgCoverArtFullSize::slotLoadTrack(nullptr) for some reason..)
  • only closing the parent DlgTrackInfo will close the cover window

Version

2.3.3 and 2.4-alpha

OS

Ubuntu Studio 20.04 / X11 / xfce 4.14 / Qt 5.12.8

@ronso0 ronso0 added the bug label Oct 28, 2022
@ronso0
Copy link
Member Author

ronso0 commented Oct 28, 2022

Issue seems to be that close() in DlgCoverArtFullSize::slotCoverFound does nothing.

IMO to fix this sustainably a bigger refactoring is required, it just doesn't make sense to me that the dialog is opened and then closed again if no cover is found.
DlgCoverArtFullSize shouldn't be opened in the first place if no cover is found, similiar to how it's done in WCoverArt::mouseReleaseEvent

@ronso0
Copy link
Member Author

ronso0 commented Oct 28, 2022

or maybe #11022 is sufficient

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant