Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.3.0 LoadSelectedTrack no longer works #9935

Closed
mixxxbot opened this issue Aug 23, 2022 · 6 comments
Closed

v2.3.0 LoadSelectedTrack no longer works #9935

mixxxbot opened this issue Aug 23, 2022 · 6 comments
Labels
Milestone

Comments

@mixxxbot
Copy link
Collaborator

Reported by: gsprain
Date: 2020-04-20T18:44:00Z
Status: Fix Released
Importance: High
Launchpad Issue: lp1873938


Cannot load track into either deck 1 or 2 via keyboard (Shift+Left & Shift+Right). I can drag n drop the track into the waveform. I tried changing the keyboard cfg file to use another key and got no results. For what it's worth, the eject via keyboard, as well as all other keys I've tried work fine. Currently, i don't have my controller connected, so I don't know if the issue exists there as well.

This is the 64 bit Windows version posted 04-20-2020 and started with the release posted 04-18-2020

@mixxxbot
Copy link
Collaborator Author

Commented by: uklotzde
Date: 2020-04-20T21:12:06Z


WTrackTableView::loadSelectionToGroup() and the corresponding connctions got lost

@mixxxbot mixxxbot added the bug label Aug 23, 2022
@mixxxbot
Copy link
Collaborator Author

Commented by: uklotzde
Date: 2020-04-20T21:24:53Z


It is actually the override of void LibraryView::loadSelectedTrackToGroup(QString group, bool play) that is missing and became a noop due to the default implementation in the base class.

@mixxxbot
Copy link
Collaborator Author

Commented by: uklotzde
Date: 2020-04-20T21:27:31Z


void loadSelectedTrack() is also missing

@mixxxbot
Copy link
Collaborator Author

Commented by: ywwg
Date: 2020-04-22T23:28:03Z


Fixed in #2696

@mixxxbot
Copy link
Collaborator Author

Commented by: gsprain
Date: 2020-04-23T17:25:23Z


I have verified the bug has been resolved in the pversion posted 04-23-2020. Thanks, and great job!

@mixxxbot
Copy link
Collaborator Author

Issue closed with status Fix Released.

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
@mixxxbot mixxxbot added this to the 2.3.0 milestone Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant