Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make AGNES algorithm closer to R #11

Merged
merged 8 commits into from
Jul 16, 2019
Merged

refactor: make AGNES algorithm closer to R #11

merged 8 commits into from
Jul 16, 2019

Conversation

targos
Copy link
Member

@targos targos commented Jul 16, 2019

BREAKING CHANGE:

  • use the Lance-Williams algorithm to update cluster distances.
  • add other methods that exist in R.
  • remove ClusterLeaf class and use an isLeaf property instead.
  • remove index array from clusters. Instead, an indexes() method has been added to compute it.
  • add a size property to clusters that indicates the number of leaves below it.
  • the default method is now 'complete'.
  • DIANA has been removed from the package pending rewriting it.

@codecov
Copy link

codecov bot commented Jul 16, 2019

Codecov Report

Merging #11 into master will decrease coverage by 14.63%.
The diff coverage is 71.42%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #11       +/-   ##
===========================================
- Coverage   87.36%   72.72%   -14.64%     
===========================================
  Files           5        3        -2     
  Lines         269      176       -93     
  Branches       33       31        -2     
===========================================
- Hits          235      128      -107     
- Misses         33       47       +14     
  Partials        1        1
Impacted Files Coverage Δ
src/agnes.js 63.33% <66.66%> (-12.53%) ⬇️
src/Cluster.js 91.48% <88.88%> (-3.52%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5266b90...7788cc5. Read the comment docs.

@targos targos merged commit 1517124 into master Jul 16, 2019
@targos targos deleted the refactor branch July 16, 2019 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant