-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Working with Redis cluster #12
Comments
In theory LUA script can work on a Redis cluster. Unfortunately at this time I have not tested the implementation against a Redis cluster. Take a look http://www.dr-josiah.com/2014/11/introduction-to-rate-limiting-with_26.html under the subtitle 'Generating keys in the script' which discusses the requirements for utilising the LUA script with a Redis Cluster. The Redis implementation is largely based on this excellent blog post from Josiah Carlson. |
@mokies Thank you, I'll see that post. |
@danhcc it looks like we will need to rework some of the interfaces to support a clustered connection. I will give it a shot and get back to you. |
@mokies Thanks in advance |
@mokies we'd also like to use ratelimitj with cluster support so just making you aware that adding this support would be highly appreciated :) |
@mokies I gave a shot to modify the ratelimitj framework to support redis cluster mode for our application and it seems to work fine so far. Would you mind taking a look if I create a pull request? |
Thanks @Meyy-DL I will definitely take a look and merge it into master. Apologies that I haven't got around to support this yet. |
1 |
Apologies for the delay, my day job has been a little full on these past months @Meyy-DL appreciate the PR. I am currently working on a change to support a clustered Redis but want to be sure the change has appropriate test coverage before rolling it out. |
Redis Cluster support is looking good, see 3b2c0cb |
@mokies Thank you! Highly appreciate it! |
I am wondering if this could be use with Redis cluster.
As far as I know, LUA scripts does not work with Redis cluster.
Can someone explain this to me please.
The text was updated successfully, but these errors were encountered: