Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(emx2-pyclient): make keep_default_na a parameter in "get" #4354

Open
dtroelofsprins opened this issue Oct 14, 2024 · 0 comments
Open

feat(emx2-pyclient): make keep_default_na a parameter in "get" #4354

dtroelofsprins opened this issue Oct 14, 2024 · 0 comments

Comments

@dtroelofsprins
Copy link
Contributor

Is your feature request related to a problem? Please describe.
When retrieving data using the get method from the emx2-pyclient, the API response is transformed into a dataFrame using pd.read_csv with keep_default_na = False. It turns out that if a column contains missing value all cells become type=str. Which might in some cases result in unexpected results.

Describe the solution you'd like
Make the keep_default_na optional (so include it as a parameter) with default option = False for backwards compatibility.

Describe alternatives you've considered

  • rewrite data handling to take into account that integers and bools are strings

Additional context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant