Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add OMIA non-human animal diseases #7870

Merged
merged 6 commits into from
Jun 28, 2024
Merged

add OMIA non-human animal diseases #7870

merged 6 commits into from
Jun 28, 2024

Conversation

katiermullen
Copy link
Collaborator

addresses #7225 Adds species agnostic non-human animal diseases that do not have x-species analogs to human diseases.

addresses #7225 Adds species agnostic non-human animal diseases that do not have x-species analogs to human diseases.
fix qc fail from "unsatisfiable" class error
add single child exclusions
update with normalization
Copy link
Collaborator

@sabrinatoro sabrinatoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@katiermullen there are a few comments. Nothing major.
There are a few terms for which I saw that we might have a human x-species. Also, I wonder if any of these could be children of each other. Some were "obvious" to spot. That being said, it is possible that it should not.
Please take a look. We can also update these parentages in another PR.

There are a few minor typos here and there. Whoever gets there first! :-)

Thank you! That's a lot of work!

src/ontology/mondo-edit.obo Show resolved Hide resolved
src/ontology/mondo-edit.obo Show resolved Hide resolved
src/ontology/mondo-edit.obo Show resolved Hide resolved
src/ontology/mondo-edit.obo Show resolved Hide resolved
src/ontology/mondo-edit.obo Show resolved Hide resolved
src/ontology/mondo-edit.obo Show resolved Hide resolved
src/ontology/mondo-edit.obo Show resolved Hide resolved
src/ontology/mondo-edit.obo Show resolved Hide resolved
src/ontology/mondo-edit.obo Show resolved Hide resolved
src/ontology/mondo-edit.obo Show resolved Hide resolved
resolved comments and made suggested changes
Copy link
Collaborator

@sabrinatoro sabrinatoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@katiermullen this looks good. This PR can be merged. One more step in the non-human animal disease route!

@sabrinatoro sabrinatoro merged commit b3a7a72 into master Jun 28, 2024
1 check passed
@sabrinatoro sabrinatoro deleted the 240627-omia branch June 28, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants