You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
which on the one hand is nice as new matchers can easily be slotted in.
however, different matchers will have different parameterization, and may have differences in payloads. While this could be handled by generic property-value methods, not clear this abstraction is helpful. And it's not like we will have that many matchers in production. Or that it would be hard to add specific routes, it's not that much boilerplate.
It may be clearer to have distinct routes:
/match/phenodigm/
/match/bnb/
Advantages:
distinct swagger documentation for each
method-specific parameters are explicit and documented in swagger
less guice
The text was updated successfully, but these errors were encountered:
Currently the route is
/match/{matcher}/...
which on the one hand is nice as new matchers can easily be slotted in.
however, different matchers will have different parameterization, and may have differences in payloads. While this could be handled by generic property-value methods, not clear this abstraction is helpful. And it's not like we will have that many matchers in production. Or that it would be hard to add specific routes, it's not that much boilerplate.
It may be clearer to have distinct routes:
/match/phenodigm/
/match/bnb/
Advantages:
The text was updated successfully, but these errors were encountered: