Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make specific routes for the different matchers #63

Open
cmungall opened this issue Mar 3, 2017 · 0 comments
Open

Make specific routes for the different matchers #63

cmungall opened this issue Mar 3, 2017 · 0 comments

Comments

@cmungall
Copy link
Member

cmungall commented Mar 3, 2017

Currently the route is

/match/{matcher}/...

which on the one hand is nice as new matchers can easily be slotted in.

however, different matchers will have different parameterization, and may have differences in payloads. While this could be handled by generic property-value methods, not clear this abstraction is helpful. And it's not like we will have that many matchers in production. Or that it would be hard to add specific routes, it's not that much boilerplate.

It may be clearer to have distinct routes:

  • /match/phenodigm/
  • /match/bnb/

Advantages:

  • distinct swagger documentation for each
  • method-specific parameters are explicit and documented in swagger
  • less guice
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant