Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website isn't detecting browser/OS language #903

Closed
erciccione opened this issue Apr 12, 2020 · 5 comments
Closed

Website isn't detecting browser/OS language #903

erciccione opened this issue Apr 12, 2020 · 5 comments
Labels

Comments

@erciccione
Copy link
Contributor

Issue originally created by @asdrub

This issue was created on gitlab and then migrated here. Only the original post was migrated, not the comments. Please take a look at the discussions on the original Gitlab issue before commenting here: https://repo.getmonero.org/monero-project/monero-site/-/issues/1030


The website doesn't change automatically to the language of the Browser or OS, even when there is a translated version available. The user must always select the language in the menu.

@erciccione
Copy link
Contributor Author

I did some research on this. Without using javascript, autodetecting a language is quite annoying. There are other solutions, like serving a cookie and use PHP, but this would be more complex from a legal point of view.

I'm by no mean an expert in this, if somebody has deeper knowledge about this or have a solution in mind, please share your thoughts.

@00-matt
Copy link
Contributor

00-matt commented Sep 13, 2020

We can look at the user's Accept-Language header in nginx and redirect appropriately. Maybe something like this:

map $http_accept_language $lang {
    default en;
    ~es es;
    ~fr fr;
    # ...
}

...

rewrite (.*) $lang/$1;

We could also store a cookie when a user selects a language (without PHP), and then redirect them next time based on that.

@erciccione
Copy link
Contributor Author

erciccione commented Sep 13, 2020

We can look at the user's Accept-Language header in nginx

Yes, that's probably the best solution.

We could also store a cookie when a user selects a language

That would create problems from a legal point of view and will force us to show an annoying disclaimer. As i just wrote on #monero-site:

i really don't see auto detection as an important feature to have, so i wouldn't really bother with anything more complex than tweaking nginx (i'm referring to using cookies)
complex from a legal point of view

@erciccione
Copy link
Contributor Author

I'm looking into this. I asked suggestions to pigeons.

@XfedeX
Copy link

XfedeX commented May 16, 2022

Aren't cookie disclaimers needed by the GDPR only if cookies can uniquely identify your browser or are used for tracking reasons?

As Regulation (EU) 2016/679 of the European Parlament and of the council of 27 April 2016 states:

Natural persons may be associated with online identifiers provided by their devices, applications, tools and protocols, such as internet protocol addresses, cookie identifiers or other identifiers such as radio frequency identification tags. This may leave traces which, in particular when combined with unique identifiers and other information received by the servers, may be used to create profiles of the natural persons and identify them.

If I am correct, a language cookie cannot be used to identify you. For this reason I do not think that a disclaimer would be needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants