-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shouldn't Request.JSON fire 'complete' event on JSON errors? #2764
Comments
Maybe If we keep it like it is it should at least be documented. |
Not sure about firing IMHO the three possible options are, in order of my preference:
|
I'm ok with |
(sorry, I accidentally clicked the wrong button) |
When
Request.JSON
fails because response cannot be correctly parsed, the'error'
event is fired.'error'
is not an event inherit fromRequest
, and is fired here:Shouldn't it fire also the
'complete'
event? I use'complete'
, for example, to hide progress indicators (like spinners), and for me the request is completed in case of errors too. Maybe my assumption is wrong, but then why the'failure'
event does it my way instead?Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
The text was updated successfully, but these errors were encountered: