Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite of ProxyServer class #2

Open
cusspvz opened this issue Sep 3, 2014 · 3 comments
Open

Rewrite of ProxyServer class #2

cusspvz opened this issue Sep 3, 2014 · 3 comments

Comments

@cusspvz
Copy link
Member

cusspvz commented Sep 3, 2014

This Issue will host all contributors ideas to implement ProxyServer in a new way.

Rewrite should happen at rewrite branch.

@cusspvz
Copy link
Member Author

cusspvz commented Sep 17, 2014

@cusspvz
Copy link
Member Author

cusspvz commented Sep 17, 2014

Things that we need to change:

  • ProxyServer class is created on each .proxy call instead of each Server type
  • Super class shouldn't be implemented this way, (maybe this is the cause of Sockets are leaking #4 ? )
  • I believe that connection stages should be divided into files.
  • Tests aren't covering everything... help wanted
  • We have to create a milestone with all changes discussed here, we must discuss if we can maintain the current API.

@sadasant
Copy link

Sure, I'll think on that in the following days. I'm traveling right now!
Thanks for the opportunity.
On Sep 17, 2014 7:03 PM, "José Moreira" notifications@github.com wrote:

Things that we need to change:

  • ProxyServer class is created on each .proxy call instead of each
    Server type
  • Super class shouldn't be implemented this way, (maybe this is the
    cause of Sockets are leaking #4 Sockets are leaking #4 ? )
  • I believe that connection stages should be divided into files.
  • Tests aren't covering everything... help wanted
  • We have to create a milestone with all changes discussed here, we
    must discuss if we can maintain the current API.


Reply to this email directly or view it on GitHub
#2 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants