Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does this work with Node v12 LTS and HTTP/2? #30

Open
niftylettuce opened this issue Jul 6, 2020 · 3 comments
Open

Does this work with Node v12 LTS and HTTP/2? #30

niftylettuce opened this issue Jul 6, 2020 · 3 comments

Comments

@niftylettuce
Copy link

No description provided.

@niftylettuce niftylettuce mentioned this issue Jul 6, 2020
@cusspvz
Copy link
Member

cusspvz commented Jul 6, 2020

Hey @niftylettuce !

I believe the PROXY protocol standards for HTTP 1.X apply the same way for HTTP 2.X. Although, there are two versions of the proxy protocol and this only covers the version 1.

If you feel like you want to contribute to this, feel free to add support to it.

@niftylettuce
Copy link
Author

Any chance I could tip/sponsor you for adding/testing HTTP/2 and optionally if you had the time; PROXY v2? Toss me an email if so, niftylettuce@gmail.com

@niftylettuce
Copy link
Author

This doesn't work with HTTP/2 right now because http2 doesn't export a Server property like http does, and therefore it doesn't inherit anything and throws this error:

util.js:157
    throw new ERR_INVALID_ARG_TYPE('superCtor', 'Function', superCtor);
    ^

TypeError [ERR_INVALID_ARG_TYPE]: The "superCtor" argument must be of type function. Received undefined
    at Object.inherits (util.js:157:11)
    at Object.exports.proxy (/Users/user/Projects/project/node_modules/findhit-proxywrap/lib/proxywrap.js:148:8)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants