Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BSD license with dependency on GPL-3.0 findhit-util #36

Closed
TjlHope opened this issue Apr 22, 2022 · 2 comments
Closed

BSD license with dependency on GPL-3.0 findhit-util #36

TjlHope opened this issue Apr 22, 2022 · 2 comments

Comments

@TjlHope
Copy link

TjlHope commented Apr 22, 2022

Hi, I found this project as we're looking to use farhadi/node-smpp (which depends on it) in a commercial project.

node-smpp is MIT and this project (from the package.json) is BSD (though I did see #3 ), but proxywrap has a dependency on findhit-util which is GPL-3.0, meaning any derivative work (i.e. project using it) needs to be GPL as well.

Would you be willing to accept a PR removing the findhit-util GPL dep? (AFAICT it's only used for Util.extend and Util.is.object, which could be trivially replaced with equivalent methods from lodash)

@cusspvz
Copy link
Member

cusspvz commented Apr 24, 2022

Sure, makes sense. As you said, these seem trivial and easily replaceable. If you push a PR, once we land it, I'll launch a new patch release for the license change.

@TjlHope
Copy link
Author

TjlHope commented Apr 25, 2022

Sorry about the spam there - I kept tweaking it without realising it would keep adding messages.

BTW yarn was complaining at me that the license (BSD) isn't a valid SPDX identifier - I'm assuming you mean it to be either 0BSD or BSD-3-Clause? (Not that it really matters for us)

Thanks!

@cusspvz cusspvz closed this as completed in d96ffd1 May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants