On iOS 6, when selecting multiple files, only the first one gets added to the queue

[frahugo]

Seems to be related to this commit: 037e154

[tiff]

I can confirm that. Same here.

[daparky]

Yep, i can also confirm. I also noticed that the filename is always called image too.

[tiff]

I fixed this in my fork.
See protonet@9e2de0a

Feel free to use the fork. Basically it's plupload HEAD + some neat extras (eg. drag & drop support for directories in chrome).

[daparky]

Maybe you should submit a pull request with these changes?

On 24 Sep 2012, at 14:30, Christopher Blum notifications@github.com wrote:

I fixed this in my fork.
See protonet/plupload@9e2de0a

Feel free to use the fork. Basically it's plupload HEAD + some neat extras (eg. drag & drop support for directories in chrome).

—
Reply to this email directly or view it on GitHub.

[bistory]

@daparky There is already plenty of PR and no one integrate them. The project is stalled for 5 months...

[tiff]

@daparky I already did for the other changes (#587). Since nobody was interested in merging or discussing it I didn't feel the need to maintain multiple branches for multiple pull requests in my repo (especially since my changes overlap).

[daparky]

Thanks for the update. Is this project dead?

[gabor]

@tiff what do you think about this fix? https://gist.github.com/3833936 . it limits the multiple-files-with-same-name manipulation to safari-on-windows, so ios6 works normally.

[tiff]

@gabor The problem with your approach is that still all images will share the same name (image.jpg) which makes it hard to save them on the server side as they would override themselves. I for example use plupload for a web-based file manager where I store uploaded files with their original name.

[gabor]

@tiff i see. yes, that would be a problem. in my case i ignore the filenames on the server-side, so it is fine for me... btw. my problem with the solution you use is, that i'm worried about false positives. for example, imagine the user is trying to upload these files: image.jpg, image_1.jpg, image_2.jpg. your solution would ignore the second file (the originally called image1.jpg), if i'm not mistaken. perhaps the check should be if every file in the array is called image.jpg then do the renaming or something like that... will have to think about it a bit more :-)

[gabor]

@tiff .. after more thinking...
the question is if plupload should guarantee unique filenames or not.

i think it should not, because "filename-uniquification" (is that a word? :-) can still be achieved by registering an event handler on "FilesAdded", and simply modify the filenames at that point. no modification of plupload required. (haven't tried it yet, but it should work if i'm reading the code correctly)

of course, all this is IMHO

[tiff]

@gabor The fact that ios names every image "image.jpg" should be considered a bug (if you upload a video on ios instead the file names are unique).
Libraries like plupload exist to hide bugs from the user.

imho :)

PS: Thanks for pointing out a problem with my patch.

[morgstar]

I noticed there's no plupload.full.js in your source files tiff. is it a matter of incorporating your forked html5 js file into the plupload.full.js file if we want to have access to all runtimes as well as your forked version??

[jayarjo]

Ok, so here we are, after a last deep dive for Plupload 2. And I also got an iPad at last, so let me come up with some solution here finally.

[blue-j]

I'm willing to fund a solution to this, if that's any help...! drop me a note! (referring to issue 623 - the multiple file failure on iOS 6)

[jewel]

@blue-j I've been using the https://github.com/protonet/plupload fork, which doesn't have this issue.

[jayarjo]

This has been fixed. For 1.x branch here: 48c110e. And Plupload 2 was free of this bug from the start.

[blue-j]

I'm not a developer but the linked edit appears to be for Safari on Windows only and not on mobile, right? I understand it had the same bug. Sorry if I am reading this incorrectly.

Thanks so much!! I appreciate your time and effort and am grateful.
J

On Mar 28, 2013, at 2:24 AM, Davit Barbakadze notifications@github.com wrote:

This has been fixed. For 1.x branch here: 48c110e. And Plupload 2 was free of this bug from the start.

—
Reply to this email directly or view it on GitHub.

[jayarjo]

Originally it affected all Safaries, although the only one to fix was Safari on Windows. So what you've experienced was a fix, rather than a bug. Just too broad - shouldn't have affected mobile Safari :)

[blue-j]

Please forgive me for being daft, but I'm still unclear on where this stands on mobile? We are using 1.5.4 presently and just trying to solve this ASAP.

Thanks again!!
J

On Mar 28, 2013, at 6:29 AM, Davit Barbakadze notifications@github.com wrote:

Originally it affected all Safaries, although the only one to fix was Safari on Windows. So what you've experienced was a fix, rather than a bug. Just too broad - shouldn't have affected mobile Safary :)

—
Reply to this email directly or view it on GitHub.

[jayarjo]

Well you could use latest js source from 1x branch or try Plupload 2. Bugfix release for 1.x branch is not yet released, scheduled for Monday.

[blue-j]

You've been very kind and generous with your time.  Thank you!  We've implemented the fix locally with success!

Davit Barbakadze notifications@github.com , 3/28/2013 4:27 PM:

Well you could use js source from 1x branch or try Plupload 2. Bugfix release for 1.x branch is not yet released, scheduled for Monday.

—
Reply to this email directly or view it on GitHub.

[NightmaresWithin]

I tried Plupload 2 with the same results. Also, the percentage indicator does not advance on my iPad3, but it does upload (only one image of course because the naming still stayed duplicate). Wish I could help more. I will try the 1x branch. Thanks again for all your hard work. :)

[blue-j]

We applied the linked fix edit manually, and it worked, at least on iOS 6.1.3 on an iPhone 5.

On Apr 5, 2013, at 8:27 PM, Nightmares Within notifications@github.com wrote:

I tried Plupload 2 with the same results. Also, the percentage indicator does not advance on my iPad3, but it does upload (only one image of course because the naming still stayed duplicate). Wish I could help more. I will try the 1x branch. Thanks again for all your hard work. :)

—
Reply to this email directly or view it on GitHub.

[daparky]

This will only work on devices with ios 6+ because safari uploading is disabled prior.

On 6 Apr 2013, at 04:27, Nightmares Within notifications@github.com wrote:

I tried Plupload 2 with the same results. Also, the percentage indicator does not advance on my iPad3, but it does upload (only one image of course because the naming still stayed duplicate). Wish I could help more. I will try the 1x branch. Thanks again for all your hard work. :)

—
Reply to this email directly or view it on GitHub.

[jayarjo]

I tried Plupload 2 with the same results.

What kind of same results?

@NightmaresWithin you can use unique_names option to avoid overwriting on the server-side. iOS doesn't provide any hint on what the file name should be. Although we might probably auto append numeric suffix to the name for iOS only. I will consider that.

[blue-j]

I think the suggestion to auto-append a suffix is smart. It does give the wrong impression about what's happening in iOS though (filename not being the identifier) - but I suspect it's worth it.

On Apr 6, 2013, at 2:17 PM, Davit Barbakadze notifications@github.com wrote:

@NightmaresWithin you can use unique_names option to avoid overwriting on the server-side. iOS doesn't provide any hint on what the file name should be. Although we might auto append numeric suffix to the name for iOS only. I will consider that.

—
Reply to this email directly or view it on GitHub.