Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings - Sort by distance does not work for virtual beacons #367

Open
isabelrios opened this issue Nov 24, 2016 · 3 comments
Open

Settings - Sort by distance does not work for virtual beacons #367

isabelrios opened this issue Nov 24, 2016 · 3 comments

Comments

@isabelrios
Copy link
Contributor

Steps
Turn on Sort by distance settings
Fake position 1
Open the app with POI1, POI2
Fake position to a different position 2 with POI3

Actual
The list view shows PO1, PO2 and POI3 in that order

Expected
POI3 should be the first one in the list after changing the position

@wilsonpage
Copy link
Collaborator

@gmarty perhaps we should be calculating distance for virtual beacons before they are used in any view so that we can show distance and sort in list view.

@gmarty
Copy link
Contributor

gmarty commented Nov 24, 2016

The calculation must still be done in JavaScript-land and via React so they get updated whenever the user location changes.
I guess the fix is to do computation in the ListView component too.

@oteo
Copy link
Member

oteo commented Nov 25, 2016

If this is not working, I think we should not show this setting in the Release builds as we did with with "Show distance" setting. What do you think @wilsonpage @arcturus ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants