Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(driver): add basic chrome.storage.local driver #299

Closed

Conversation

vikrantpogula
Copy link

I've written a basic driver for using chrome.storage.local inside Chrome Packaged Apps. It works pretty well for my application but it's kind of hacky in places.

Just putting it here so that others can try it / find issues and help me in writing tests and making this good enough for inclusion.

requested in #43

chrome storage API : https://developer.chrome.com/extensions/storage

@vikrantpogula
Copy link
Author

for anyone else looking into it the main issue here when compared with localStorage / localStorageWrapper is that the chrome API ( chrome.storage.local ) seems to do some kind of internal serialize/deserialize.

I will work on this further and try to implement proper serialization for all data types

@tofumatt
Copy link
Member

I've thought about this more and it's out of scope for localForage to include in its base functionality, but thanks to our custom driver API you could release it as its own module and get users to extend localForage with it.

Sorry for the hassle of you going through a pull request for it, but I think you should release this as your own library and add it to the Wiki. I've created a page for custom drivers and will link to it from the README (#325)

@tofumatt tofumatt closed this Dec 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants