Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release zips should contain more files #4885

Closed
mgol opened this issue Jun 3, 2014 · 3 comments
Closed

Release zips should contain more files #4885

mgol opened this issue Jun 3, 2014 · 3 comments
Labels
Milestone

Comments

@mgol
Copy link
Contributor

mgol commented Jun 3, 2014

There are some files needed for high-profile PDF.js functionality like text-selection that are not included in release zips at http://mozilla.github.io/pdf.js/getting_started/#download by default. They're included in sandboxes like

<script src="../../web/pdf_find_bar.js"></script>
<script src="../../web/pdf_find_controller.js"></script>
<script src="../../web/ui_utils.js"></script>
<script src="../../web/text_layer_builder.js"></script>

@yurydelendik yurydelendik added this to the 2014 Q3 milestone Jun 19, 2014
@hastebrot
Copy link

Yes, that would make some things easier.

I'm using Bower and had to install the packages pdfjs and pdfjs-bower to use dist/pdf.js and web/text_layer_builder.js together. Instead I'd like to use the release archives directly from https://github.com/mozilla/pdf.js/releases, if they are bundled with the additional files. 😄

@yurydelendik
Copy link
Contributor

(some preparation patches at #5327 and #5295)

@yurydelendik yurydelendik modified the milestones: 2014 Q4, 2014 Q3 Sep 23, 2014
@yurydelendik
Copy link
Contributor

Fixed by #5363. The UI API is not designed yet, but you are welcome to submit feedback. It easy to expose TextLayerBuilder if needed -- please, submit a PR. I started some at https://github.com/yurydelendik/pdf.js/tree/pdfpageview but not sure how API will look like yet. Closing this one, since it looks like it fixes "release zips contain more files with extra functionality" concern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants