A few small tweaks of the SecondaryToolbar code #3824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
Should be good to go after this has been addressed. |
|
@timvandermeij Thanks for noticing, I have no idea how I missed that! /botio-windows preview |
From: Bot.io (Windows)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/ed660415ab3f6e5/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/ed660415ab3f6e5/output.txt Total script time: 0.31 mins Published
|
timvandermeij
added a commit
that referenced
this pull request
Oct 18, 2013
A few small tweaks of the SecondaryToolbar code
|
Nice, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes the following small changes to the SecondaryToolbar code:
PresentationMode, instead of using the global.isOpengetter, since it should be sufficient to just checkSecondaryToolbar.opened. This is also analogous to, for example:PDFFindBarandPasswordPrompt.buttonContaineris defined whensetMaxHeightis called. This prevents an error when reloading the viewer in "Responsive Design Mode" in Firefox.