Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dist/test is not being generated #348

Closed
Standard8 opened this issue Jun 21, 2018 · 2 comments
Closed

dist/test is not being generated #348

Standard8 opened this issue Jun 21, 2018 · 2 comments
Labels
needs-triage Unconfirmed issues

Comments

@Standard8
Copy link
Member

According to the source-map upgrading document in mozilla-central:

    $ npm install
    $ npm run-script build  -or-  nodejs Makefile.dryice.js (if you have issues with npm)
    $ cp dist/source-map.js /path/to/mozilla-central/devtools/shared/sourcemap/source-map.js
    $ cp dist/test/* /path/to/mozilla-central/devtools/shared/sourcemap/tests/unit/

Unfortunately, when I checked out latest master, the last command is failing because dist/test/* isn't generated. I took a brief look through the commit messages but couldn't see any obvious reason.

@jkrems
Copy link
Collaborator

jkrems commented Apr 18, 2021

Is this still causing issues?

@jkrems jkrems added the needs-triage Unconfirmed issues label Apr 18, 2021
@ochameau
Copy link
Contributor

ochameau commented Oct 7, 2022

dist folder has been removed in #362.

As of today, mozilla-central pulls the source-map package via npm from here:
https://searchfox.org/mozilla-central/rev/d416a7b827c2d76b12848e355a4e03dde49ece25/devtools/client/debugger/packages/devtools-source-map/package.json#24
(Note that I'll probably revisit this way of vendoring the source-map package)

So I believe this issue is now invalid. The package is meant to be used as is, as a node package and not longer use webpack itself.
If you need to build a bundle you should do that outside of this repo to avoid pulling webpack as a dependency.

@ochameau ochameau closed this as completed Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-triage Unconfirmed issues
Projects
None yet
Development

No branches or pull requests

3 participants