-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Honor media HTML attribute for link icon #495
Comments
@beaufortfrancois if you take the definition literally, it's not just a decision you make when fetching. So resizing the window would have to change the icon. Is that what you are planning on doing? If not, some changes might be needed here. Either way it seems somewhat reasonable to support this. cc @emilio |
I'm not sure the spec should define which media features should affect the favicon displayed in the browser tab. As noted in the HTML spec as well,
|
Wait, what is this issue about then, if not the favicon displayed in the browser tab? What do you think the spec is taking about, if not that? |
I don't think "matches the environment" has wiggle room to ignore certain media features. I also don't think the list of icons actually changes in this case, but the processing model is not as clear as it could be. |
Indeed, Chrome will update icons when media features change (e.g. dark/light mode change, viewport resize). |
Thanks for clarifying. I think this is worth prototyping, but I'm not entirely sure it's worth adding it to the dashboard... |
Which dashboard sorry? |
https://mozilla.github.io/standards-positions/. More of a thing we need to sort out with requests for positions on relatively minor features. |
FYI I've just sent an intent to ship at https://groups.google.com/a/chromium.org/g/blink-dev/c/OwUSsHWokpA |
I'll close this next week. If anyone doesn't think this is worth prototyping, now would be a good time to weigh in. |
Request for Mozilla Position on an Emerging Web Specification
Other information
Browsers don’t currently honor the media attribute for link[rel="icon"] even though the HTML specification says they should.
Members of the Google Chrome team are thinking of honoring the link element’s "media" attribute for link[rel="icon"] so that web developers can define multiple equally appropriate icons based on a media query (dark and light modes for instance). The last one that matches will be picked.
The text was updated successfully, but these errors were encountered: