Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for node 0.11 #86

Closed
nunorafaelrocha opened this issue Dec 13, 2014 · 7 comments
Closed

Add support for node 0.11 #86

nunorafaelrocha opened this issue Dec 13, 2014 · 7 comments

Comments

@nunorafaelrocha
Copy link

It would be great to have support for node 0.11 😄

@ghost
Copy link

ghost commented Jan 10, 2015

yeah, 0.12 (which is 0.11 made stable) is a few weeks away and many folks on 0.10 are waiting for it to flip the switch.
It would be bad having this lib holding me back

@mscdex
Copy link
Owner

mscdex commented Jan 10, 2015

"a few weeks away" -- I got a chuckle out of that one 😆

But seriously, I am open to pull requests to nan-ify the module. I just don't have the time currently.

@nicokaiser
Copy link

There is a fork by @Leonidaz who seems to work on Node 0.12 (nan) support! Yeah!
https://github.com/Leonidaz/node-mariasql/

@Leonidaz
Copy link
Contributor

we're just waiting form @mscdex to do some testing and performance regressions before merging. maybe there is a faster way to do some string creation.

@nicokaiser
Copy link

@Leonidaz That's awesome! Thanks for the great work!

@mscdex
Copy link
Owner

mscdex commented Apr 2, 2015

The work from @Leonidaz was landed in aaea5a5. I encourage everyone to also give the rewrite a try. Just about all features are implemented.

@mscdex mscdex closed this as completed Apr 2, 2015
@nunorafaelrocha
Copy link
Author

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants