Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The arguments of self.start_helper_thread() should be more flexible instead of fixed as int64. #69

Open
gouchangjiang opened this issue Dec 7, 2021 · 0 comments

Comments

@gouchangjiang
Copy link

Hi, Line 320 of /runtime/communication.py should be set as [target_tensor_name, i, self.training_tensor_dtypes[target_tensor_name], , otherwise if one of the target to calculate the loss is not type int64, there will be an error.

The original code snippet:
self.start_helper_thread( self.recv_helper_thread_args, recv_helper_thread, [target_tensor_name, i, torch.int64, False], num_iterations_for_backward_threads)
, my suggestion is:
self.start_helper_thread( self.recv_helper_thread_args, recv_helper_thread, [target_tensor_name, i, self.training_tensor_dtypes[target_tensor_name], False], num_iterations_for_backward_threads).
In this case, the code is consistent with the data type specified in the main.py file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant