Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require a CI job that asserts go generate does not change code in a PR #48

Closed
masih opened this issue Jul 12, 2021 · 0 comments · Fixed by #49
Closed

Require a CI job that asserts go generate does not change code in a PR #48

masih opened this issue Jul 12, 2021 · 0 comments · Fixed by #49

Comments

@masih
Copy link
Member

masih commented Jul 12, 2021

Since code.go should never be manually edited, would it make sense to assert this by adding a CI job that:

  • checks out the code
  • runs go generate
  • fails the build if there are any uncommitted changes.

Then require that build to pass for every PR to this repo.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

run go generate on CI multiformats/go-multicodec
1 participant
@masih