From fccab5648cf3bd8a4824a760d6a758074294fe0a Mon Sep 17 00:00:00 2001 From: Oleg Voronkovich Date: Tue, 7 Jan 2020 20:07:55 +0300 Subject: [PATCH] Use short syntax for routes HTTP methods --- src/Controller/Admin/BlogController.php | 12 ++++++------ src/Controller/BlogController.php | 12 ++++++------ src/Controller/UserController.php | 4 ++-- 3 files changed, 14 insertions(+), 14 deletions(-) diff --git a/src/Controller/Admin/BlogController.php b/src/Controller/Admin/BlogController.php index 533a3e15d..884947f53 100644 --- a/src/Controller/Admin/BlogController.php +++ b/src/Controller/Admin/BlogController.php @@ -51,8 +51,8 @@ class BlogController extends AbstractController * could move this annotation to any other controller while maintaining * the route name and therefore, without breaking any existing link. * - * @Route("/", methods={"GET"}, name="admin_index") - * @Route("/", methods={"GET"}, name="admin_post_index") + * @Route("/", methods="GET", name="admin_index") + * @Route("/", methods="GET", name="admin_post_index") */ public function index(PostRepository $posts): Response { @@ -64,7 +64,7 @@ public function index(PostRepository $posts): Response /** * Creates a new Post entity. * - * @Route("/new", methods={"GET", "POST"}, name="admin_post_new") + * @Route("/new", methods="GET|POST", name="admin_post_new") * * NOTE: the Method annotation is optional, but it's a recommended practice * to constraint the HTTP methods each controller responds to (by default @@ -114,7 +114,7 @@ public function new(Request $request, SluggerInterface $slugger): Response /** * Finds and displays a Post entity. * - * @Route("/{id<\d+>}", methods={"GET"}, name="admin_post_show") + * @Route("/{id<\d+>}", methods="GET", name="admin_post_show") */ public function show(Post $post): Response { @@ -130,7 +130,7 @@ public function show(Post $post): Response /** * Displays a form to edit an existing Post entity. * - * @Route("/{id<\d+>}/edit",methods={"GET", "POST"}, name="admin_post_edit") + * @Route("/{id<\d+>}/edit", methods="GET|POST", name="admin_post_edit") * @IsGranted("edit", subject="post", message="Posts can only be edited by their authors.") */ public function edit(Request $request, Post $post, SluggerInterface $slugger): Response @@ -156,7 +156,7 @@ public function edit(Request $request, Post $post, SluggerInterface $slugger): R /** * Deletes a Post entity. * - * @Route("/{id}/delete", methods={"POST"}, name="admin_post_delete") + * @Route("/{id}/delete", methods="POST", name="admin_post_delete") * @IsGranted("delete", subject="post") */ public function delete(Request $request, Post $post): Response diff --git a/src/Controller/BlogController.php b/src/Controller/BlogController.php index 847d70e2c..3247b1b06 100644 --- a/src/Controller/BlogController.php +++ b/src/Controller/BlogController.php @@ -37,9 +37,9 @@ class BlogController extends AbstractController { /** - * @Route("/", defaults={"page": "1", "_format"="html"}, methods={"GET"}, name="blog_index") - * @Route("/rss.xml", defaults={"page": "1", "_format"="xml"}, methods={"GET"}, name="blog_rss") - * @Route("/page/{page<[1-9]\d*>}", defaults={"_format"="html"}, methods={"GET"}, name="blog_index_paginated") + * @Route("/", defaults={"page": "1", "_format"="html"}, methods="GET", name="blog_index") + * @Route("/rss.xml", defaults={"page": "1", "_format"="xml"}, methods="GET", name="blog_rss") + * @Route("/page/{page<[1-9]\d*>}", defaults={"_format"="html"}, methods="GET", name="blog_index_paginated") * @Cache(smaxage="10") * * NOTE: For standard formats, Symfony will also automatically choose the best @@ -63,7 +63,7 @@ public function index(Request $request, int $page, string $_format, PostReposito } /** - * @Route("/posts/{slug}", methods={"GET"}, name="blog_post") + * @Route("/posts/{slug}", methods="GET", name="blog_post") * * NOTE: The $post controller argument is automatically injected by Symfony * after performing a database query looking for a Post with the 'slug' @@ -83,7 +83,7 @@ public function postShow(Post $post): Response } /** - * @Route("/comment/{postSlug}/new", methods={"POST"}, name="comment_new") + * @Route("/comment/{postSlug}/new", methods="POST", name="comment_new") * @IsGranted("IS_AUTHENTICATED_FULLY") * @ParamConverter("post", options={"mapping": {"postSlug": "slug"}}) * @@ -140,7 +140,7 @@ public function commentForm(Post $post): Response } /** - * @Route("/search", methods={"GET"}, name="blog_search") + * @Route("/search", methods="GET", name="blog_search") */ public function search(Request $request, PostRepository $posts): Response { diff --git a/src/Controller/UserController.php b/src/Controller/UserController.php index 93a1aff9d..0de4cd189 100644 --- a/src/Controller/UserController.php +++ b/src/Controller/UserController.php @@ -31,7 +31,7 @@ class UserController extends AbstractController { /** - * @Route("/edit", methods={"GET", "POST"}, name="user_edit") + * @Route("/edit", methods="GET|POST", name="user_edit") */ public function edit(Request $request): Response { @@ -55,7 +55,7 @@ public function edit(Request $request): Response } /** - * @Route("/change-password", methods={"GET", "POST"}, name="user_change_password") + * @Route("/change-password", methods="GET|POST", name="user_change_password") */ public function changePassword(Request $request, UserPasswordEncoderInterface $encoder): Response {