From 4f177c32cfb9bbd07daaaf3689fe988444ca9db8 Mon Sep 17 00:00:00 2001
From: Javier Eguiluz <javier.eguiluz@gmail.com>
Date: Fri, 20 Jul 2018 15:00:17 +0200
Subject: [PATCH] Added more type hints and removed PHPdoc

---
 src/Command/AddUserCommand.php                               | 2 +-
 src/Command/ListUsersCommand.php                             | 5 +----
 src/Twig/AppExtension.php                                    | 2 +-
 .../Form/DataTransformer/TagArrayToStringTransformerTest.php | 4 +---
 4 files changed, 4 insertions(+), 9 deletions(-)

diff --git a/src/Command/AddUserCommand.php b/src/Command/AddUserCommand.php
index 1456766a8..4c9ae398d 100644
--- a/src/Command/AddUserCommand.php
+++ b/src/Command/AddUserCommand.php
@@ -230,7 +230,7 @@ private function validateUserData($username, $plainPassword, $email, $fullName)
      * it's too long, it's better to define a separate method to maintain the
      * code readability.
      */
-    private function getCommandHelp()
+    private function getCommandHelp(): string
     {
         return <<<'HELP'
 The <info>%command.name%</info> command creates new users and saves them in the database:
diff --git a/src/Command/ListUsersCommand.php b/src/Command/ListUsersCommand.php
index 7287144f4..8cc0490b7 100644
--- a/src/Command/ListUsersCommand.php
+++ b/src/Command/ListUsersCommand.php
@@ -127,11 +127,8 @@ protected function execute(InputInterface $input, OutputInterface $output)
 
     /**
      * Sends the given $contents to the $recipient email address.
-     *
-     * @param string $contents
-     * @param string $recipient
      */
-    private function sendReport($contents, $recipient)
+    private function sendReport(string $contents, string $recipient): void
     {
         // See https://symfony.com/doc/current/cookbook/email/email.html
         $message = $this->mailer->createMessage()
diff --git a/src/Twig/AppExtension.php b/src/Twig/AppExtension.php
index 323dc386f..bdb4ec608 100644
--- a/src/Twig/AppExtension.php
+++ b/src/Twig/AppExtension.php
@@ -33,7 +33,7 @@ class AppExtension extends AbstractExtension
     private $localeCodes;
     private $locales;
 
-    public function __construct(Markdown $parser, $locales)
+    public function __construct(Markdown $parser, string $locales)
     {
         $this->parser = $parser;
         $this->localeCodes = explode('|', $locales);
diff --git a/tests/Form/DataTransformer/TagArrayToStringTransformerTest.php b/tests/Form/DataTransformer/TagArrayToStringTransformerTest.php
index 2ea609a79..c587a82f9 100644
--- a/tests/Form/DataTransformer/TagArrayToStringTransformerTest.php
+++ b/tests/Form/DataTransformer/TagArrayToStringTransformerTest.php
@@ -117,10 +117,8 @@ private function getMockedTransformer(array $findByReturnValues = []): TagArrayT
 
     /**
      * This helper method creates a Tag instance for the given tag name.
-     *
-     * @param string $name
      */
-    private function createTag($name): Tag
+    private function createTag(string $name): Tag
     {
         $tag = new Tag();
         $tag->setName($name);