From 82e52fb932ddab6066a02251667b4f7bb89e7cfa Mon Sep 17 00:00:00 2001
From: Fritz Duchardt <fritz@duchardt.net>
Date: Wed, 1 Nov 2023 09:06:13 +0100
Subject: [PATCH] fix(clean-up): Call env cleanup method when executing render
 and sync

---
 internal/myks/environment.go | 57 ++++++++++++++++++++----------------
 1 file changed, 32 insertions(+), 25 deletions(-)

diff --git a/internal/myks/environment.go b/internal/myks/environment.go
index 238e7e6f..7e5a8493 100644
--- a/internal/myks/environment.go
+++ b/internal/myks/environment.go
@@ -106,6 +106,38 @@ func (e *Environment) Render(asyncLevel int) error {
 	return e.Cleanup()
 }
 
+func (e *Environment) SyncAndRender(asyncLevel int, vendirSecrets string) error {
+	if err := e.renderArgoCD(); err != nil {
+		return err
+	}
+	err := process(asyncLevel, e.Applications, func(item interface{}) error {
+		app, ok := item.(*Application)
+		if !ok {
+			return fmt.Errorf("Unable to cast item to *Application")
+		}
+		if err := app.Sync(vendirSecrets); err != nil {
+			return err
+		}
+		yamlTemplatingTools := []YamlTemplatingTool{
+			&Helm{ident: "helm", app: app, additive: true},
+			&YttPkg{ident: "ytt-pkg", app: app, additive: true},
+			&Ytt{ident: "ytt", app: app, additive: false},
+			&GlobalYtt{ident: "global-ytt", app: app, additive: false},
+		}
+		if err := app.RenderAndSlice(yamlTemplatingTools); err != nil {
+			return err
+		}
+		return app.renderArgoCD()
+	})
+
+	if err != nil {
+		log.Error().Err(err).Msg(e.Msg("Unable to sync and render applications"))
+		return err
+	}
+
+	return e.Cleanup()
+}
+
 func (e *Environment) Cleanup() error {
 	apps, err := e.renderedApplications()
 	if err != nil {
@@ -171,31 +203,6 @@ func (e *Environment) missingApplications() ([]string, error) {
 	return missingApps, nil
 }
 
-func (e *Environment) SyncAndRender(asyncLevel int, vendirSecrets string) error {
-	if err := e.renderArgoCD(); err != nil {
-		return err
-	}
-	return process(asyncLevel, e.Applications, func(item interface{}) error {
-		app, ok := item.(*Application)
-		if !ok {
-			return fmt.Errorf("Unable to cast item to *Application")
-		}
-		if err := app.Sync(vendirSecrets); err != nil {
-			return err
-		}
-		yamlTemplatingTools := []YamlTemplatingTool{
-			&Helm{ident: "helm", app: app, additive: true},
-			&YttPkg{ident: "ytt-pkg", app: app, additive: true},
-			&Ytt{ident: "ytt", app: app, additive: false},
-			&GlobalYtt{ident: "global-ytt", app: app, additive: false},
-		}
-		if err := app.RenderAndSlice(yamlTemplatingTools); err != nil {
-			return err
-		}
-		return app.renderArgoCD()
-	})
-}
-
 func (e *Environment) setId() error {
 	yamlBytes, err := os.ReadFile(e.EnvironmentDataFile)
 	if err != nil {