Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecationwarning: change_geometry in matplotlib 3.4+ #76

Closed
n-claes opened this issue Aug 13, 2021 · 0 comments · Fixed by #86
Closed

Deprecationwarning: change_geometry in matplotlib 3.4+ #76

n-claes opened this issue Aug 13, 2021 · 0 comments · Fixed by #86
Labels
bug Something isn't working pylbo Affects the post-processing framework Pylbo
Milestone
v1.2

Comments

@n-claes
Copy link
Owner

n-claes commented Aug 13, 2021

PR #69 added support for matplotlib 3.4, but apparently not all deprecationwarnings were properly handled. It seems that in some cases the warning is still triggered when the axes geometry is changed and this needs to be fixed before the 1.1 release.

Probably the easiest solution is to change how we add an additional subplot to the figure through _add_subplot_axes() in the figure manager, this should propagate automatically to all instances that use it.
@n-claes n-claes added bug Something isn't working pylbo Affects the post-processing framework Pylbo labels Aug 13, 2021
@n-claes n-claes added this to the v1.1 milestone Aug 13, 2021
@n-claes n-claes mentioned this issue Sep 8, 2021
Merged
@n-claes n-claes mentioned this issue Oct 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working pylbo Affects the post-processing framework Pylbo
Projects
None yet
Milestone
v1.2
Development

Successfully merging a pull request may close this issue.

Release version 1.2 n-claes/legolas
1 participant
@n-claes