Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idea: Saving pfx to keyvault #10

Open
egamitilps opened this issue Sep 21, 2019 · 4 comments
Open

Idea: Saving pfx to keyvault #10

egamitilps opened this issue Sep 21, 2019 · 4 comments
Labels
enhancement New feature or request

Comments

@egamitilps
Copy link

This is exactly what i'm looking for.
An enhancement I'd love to see is saving the pfx to keyvault along with the password.

Awesome work!

@n3wt0n n3wt0n added the enhancement New feature or request label Sep 23, 2019
@n3wt0n
Copy link
Owner

n3wt0n commented Sep 23, 2019

Good idea, I could add a setting for it so the user can decide if saving to keyvault or not.

Thanks :)

@hendriksteinhorst
Copy link

may I ask if there are any updates on this topic as I would love to see this feature too

@n3wt0n
Copy link
Owner

n3wt0n commented Aug 26, 2020

@hendriksteinhorst I still have plans to add that to the service, but I've been super busy and haven't had enough time to do this properly. As you can imagine it's a feature that needs to be done with the right amount of attention to be sure everything works properly.

I'm gonna do it as soon as I can.

@hendriksteinhorst
Copy link

I have done it manually recently to use the certificate in Azure Front Door. Here is what I learned:

  • Azure Front Door accepts only certificates with RSA private key (see line 145 in CertificatesHelper.cs)
  • the certificate password must be empty, otherwise Azure Front Door can't import it

I don't know the security implications of these changes as I'm no expert in certificates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants