Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing the font size? #55

Open
n4ze3m opened this issue Apr 30, 2024 Discussed in #54 · 5 comments
Open

Changing the font size? #55

n4ze3m opened this issue Apr 30, 2024 Discussed in #54 · 5 comments

Comments

@n4ze3m
Copy link
Owner

n4ze3m commented Apr 30, 2024

Discussed in #54

Originally posted by gerroon April 30, 2024
Is it possible to change the font size in the side bar? It is quite large compared to the font sizes in the web sites pages.

@GreyTeddy
Copy link

A perhaps easy fix would be to link the zoom "style" functionality to buttons - and +. The zoom can be easily changed by running document.body.style.zoom = 0.5 in the console for a 50% zoom out. Of course, buttons would be a proper solution to this.

I can make a PR with this change, if I have some free time.

@GreyTeddy
Copy link

GreyTeddy commented May 14, 2024

Sadly, it looks like the zoom "style" functionality is not yet supported by Mozilla Firefox yet. As this extension is available there as well, it will be much more involved to add zoom functionality.

Which is extra sad, because I managed to quickly do a prototype, and it actually works well on Google Chrome 😅...

EDIT: It just got support today??? hahaha, it was in preview when I first wrote this and my local firefox does not support it.
image

@GreyTeddy
Copy link

Given that it just got support (and I updated my local Firefox), I will still make a PR, and it can be decided later whether to be merged.

@GreyTeddy
Copy link

GreyTeddy commented May 14, 2024

Typescript type CSSStyleDeclaration doesn't include zoom yet (left a comment)., but should work now, as I'll put a //@ts-ignore

Also, from my testing, it looks like Ctrl + Scroll Up/Down zooms in/out the side page! But only on Firefox, not Chrome. So I'm thinking adding a setting in the Settings page

@n4ze3m
Copy link
Owner Author

n4ze3m commented May 15, 2024

Hey, this is so cool ❤️! Btw, you can check which environment the extension is in using import.meta.env.BROWSER. For Chromium-based browsers, it will be 'chrome', and for Firefox, it will be 'firefox'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants