From 90fe852e03c2d0d3b77c691a3a1959092aa51c9f Mon Sep 17 00:00:00 2001
From: Michael Kret <michael.k@radency.com>
Date: Fri, 18 Oct 2024 16:01:39 +0300
Subject: [PATCH] review update

---
 .../editor-ui/src/composables/useRunWorkflow.ts | 17 +++++++++--------
 1 file changed, 9 insertions(+), 8 deletions(-)

diff --git a/packages/editor-ui/src/composables/useRunWorkflow.ts b/packages/editor-ui/src/composables/useRunWorkflow.ts
index cd11bb8bb355d..030a52c481eb0 100644
--- a/packages/editor-ui/src/composables/useRunWorkflow.ts
+++ b/packages/editor-ui/src/composables/useRunWorkflow.ts
@@ -312,6 +312,13 @@ export function useRunWorkflow(useRunWorkflowOpts: { router: ReturnType<typeof u
 		return testUrl;
 	}
 
+	function isExecutionResolved(execution: IExecutionResponse | undefined) {
+		return (
+			execution &&
+			(execution.finished || ['error', 'canceled', 'crashed', 'success'].includes(execution.status))
+		);
+	}
+
 	async function runWorkflowResolvePending(options: {
 		destinationNode?: string;
 		triggerNode?: string;
@@ -382,10 +389,7 @@ export function useRunWorkflow(useRunWorkflowOpts: { router: ReturnType<typeof u
 						return node.name === lastNodeExecuted;
 					});
 
-					if (
-						execution.finished ||
-						['error', 'canceled', 'crashed', 'success'].includes(execution.status)
-					) {
+					if (isExecutionResolved(execution)) {
 						workflowsStore.setWorkflowExecutionData(execution);
 						if (timeoutId) clearTimeout(timeoutId);
 						resolve();
@@ -446,10 +450,7 @@ export function useRunWorkflow(useRunWorkflowOpts: { router: ReturnType<typeof u
 		// having active execution id causes issue when re-running workflow that has execution data
 		// so we remove it after execution has been resolved
 		const execution = await workflowsStore.getExecution((executionId as string) || '');
-		if (
-			execution &&
-			(execution.finished || ['error', 'canceled', 'crashed', 'success'].includes(execution.status))
-		) {
+		if (isExecutionResolved(execution)) {
 			workflowsStore.activeExecutionId = null;
 		}