diff --git a/.github/workflows/codeql.yml b/.github/workflows/codeql.yml new file mode 100644 index 00000000..1e5fc93c --- /dev/null +++ b/.github/workflows/codeql.yml @@ -0,0 +1,102 @@ +# For most projects, this workflow file will not need changing; you simply need +# to commit it to your repository. +# +# You may wish to alter this file to override the set of languages analyzed, +# or to provide custom queries or build logic. +# +# ******** NOTE ******** +# We have attempted to detect the languages in your repository. Please check +# the `language` matrix defined below to confirm you have the correct set of +# supported CodeQL languages. +# +name: "CodeQL Advanced" + +on: + pull_request: + branches: [ main, dev ] + +jobs: + analyze: + name: Analyze (${{ matrix.language }}) + # Runner size impacts CodeQL analysis time. To learn more, please see: + # - https://gh.io/recommended-hardware-resources-for-running-codeql + # - https://gh.io/supported-runners-and-hardware-resources + # - https://gh.io/using-larger-runners (GitHub.com only) + # Consider using larger runners or machines with greater resources for possible analysis time improvements. + runs-on: ${{ (matrix.language == 'swift' && 'macos-latest') || 'ubuntu-latest' }} + permissions: + # required for all workflows + security-events: write + + # required to fetch internal or private CodeQL packs + packages: read + + # only required for workflows in private repositories + actions: read + contents: read + + strategy: + fail-fast: false + matrix: + include: + - language: c-cpp + build-mode: manual + - language: python + build-mode: none + # CodeQL supports the following values keywords for 'language': 'c-cpp', 'csharp', 'go', 'java-kotlin', 'javascript-typescript', 'python', 'ruby', 'swift' + # Use `c-cpp` to analyze code written in C, C++ or both + # Use 'java-kotlin' to analyze code written in Java, Kotlin or both + # Use 'javascript-typescript' to analyze code written in JavaScript, TypeScript or both + # To learn more about changing the languages that are analyzed or customizing the build mode for your analysis, + # see https://docs.github.com/en/code-security/code-scanning/creating-an-advanced-setup-for-code-scanning/customizing-your-advanced-setup-for-code-scanning. + # If you are analyzing a compiled language, you can modify the 'build-mode' for that language to customize how + # your codebase is analyzed, see https://docs.github.com/en/code-security/code-scanning/creating-an-advanced-setup-for-code-scanning/codeql-code-scanning-for-compiled-languages + steps: + - name: Checkout repository + uses: actions/checkout@v4 + + # Initializes the CodeQL tools for scanning. + - name: Initialize CodeQL + uses: github/codeql-action/init@v3 + with: + languages: ${{ matrix.language }} + build-mode: ${{ matrix.build-mode }} + # If you wish to specify custom queries, you can do so here or in a config file. + # By default, queries listed here will override any specified in a config file. + # Prefix the list here with "+" to use these queries and those in the config file. + + # For more details on CodeQL's query packs, refer to: https://docs.github.com/en/code-security/code-scanning/automatically-scanning-your-code-for-vulnerabilities-and-errors/configuring-code-scanning#using-queries-in-ql-packs + # queries: security-extended,security-and-quality + + # If the analyze step fails for one of the languages you are analyzing with + # "We were unable to automatically build your code", modify the matrix above + # to set the build mode to "manual" for that language. Then modify this step + # to build your code. + # ℹī¸ Command-line programs to run using the OS shell. + # 📚 See https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsrun + - if: matrix.build-mode == 'manual' + shell: bash + run: | + sudo apt-get install -y lcov libcurl4-openssl-dev libmariadb-dev libmariadb-dev-compat python3 + sudo pip install pycryptodome + curl \ + -LS https://www.gnupg.org/ftp/gcrypt/libgpg-error/libgpg-error-1.50.tar.bz2 \ + -o /tmp/libgpg-error-1.50.tar.bz2 \ + && tar -xjf /tmp/libgpg-error-1.50.tar.bz2 -C /tmp/ \ + && cd /tmp/libgpg-error-1.50 \ + && sudo ./configure \ + && sudo make install \ + && curl \ + -LS https://www.gnupg.org/ftp/gcrypt/libgcrypt/libgcrypt-1.11.0.tar.bz2 \ + -o /tmp/libgcrypt-1.11.0.tar.bz2 \ + && tar -xjf /tmp/libgcrypt-1.11.0.tar.bz2 -C /tmp/ \ + && cd /tmp/libgcrypt-1.11.0 \ + && sudo ./configure \ + && sudo make install \ + && sudo ldconfig + bash ${GITHUB_WORKSPACE}/support/scripts/build_internal.sh + + - name: Perform CodeQL Analysis + uses: github/codeql-action/analyze@v3 + with: + category: "/language:${{matrix.language}}" diff --git a/src/sa/internal/sa_interface_inmemory.template.c b/src/sa/internal/sa_interface_inmemory.template.c index b10979b0..88150593 100644 --- a/src/sa/internal/sa_interface_inmemory.template.c +++ b/src/sa/internal/sa_interface_inmemory.template.c @@ -903,31 +903,31 @@ int32_t sa_get_operational_sa_from_gvcid_generate_error(int32_t* status, uint8_t // ordering so the 'most accurate' SA's error is returned // (determined by matching header fields L to R) sa_mismatched_tfvn_error(&i, status, tfvn, scid, vcid, mapid); - if(status != CRYPTO_LIB_SUCCESS) + if(*status != CRYPTO_LIB_SUCCESS) { sa_debug_block(tfvn, scid, vcid, mapid); return *status; } sa_mismatched_scid(&i, status, tfvn, scid, vcid, mapid); - if(status != CRYPTO_LIB_SUCCESS) + if(*status != CRYPTO_LIB_SUCCESS) { sa_debug_block(tfvn, scid, vcid, mapid); return *status; } sa_mismatched_vcid(&i, status, tfvn, scid, vcid, mapid); - if(status != CRYPTO_LIB_SUCCESS) + if(*status != CRYPTO_LIB_SUCCESS) { sa_debug_block(tfvn, scid, vcid, mapid); return *status; } sa_mismatched_mapid(&i, status, tfvn, scid, vcid, mapid); - if(status != CRYPTO_LIB_SUCCESS) + if(*status != CRYPTO_LIB_SUCCESS) { sa_debug_block(tfvn, scid, vcid, mapid); return *status; } sa_non_operational_sa(&i, status, tfvn, scid, vcid, mapid); - if(status != CRYPTO_LIB_SUCCESS) + if(*status != CRYPTO_LIB_SUCCESS) { sa_debug_block(tfvn, scid, vcid, mapid); return *status;