Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PSP modifications for const-correct CFE API #19

Closed
skliper opened this issue Sep 25, 2019 · 11 comments
Closed

PSP modifications for const-correct CFE API #19

skliper opened this issue Sep 25, 2019 · 11 comments
Labels
bug Something isn't working
Milestone
1.3.0

Comments

@skliper
Copy link
Contributor

skliper commented Sep 25, 2019

For context, see trac 28 in the CFE repository: [https://babelfish.arc.nasa.gov/trac/cfs_cfe/ticket/28]

The CFE API has been updated such that the pointer arguments in functions called via the PSP are now declared "const". This helps in several ways, but the most important reason is so they can be safely supplied from a data structure in ROM rather than requiring that the data structure be copied to RAM first.
@skliper skliper added this to the psp-1.3.0 milestone Sep 25, 2019
@skliper skliper self-assigned this Sep 25, 2019
@skliper
Copy link
Contributor Author

skliper commented Sep 25, 2019

Imported from trac issue 15. Created by jphickey on 2015-03-13T14:29:21, last modified: 2019-04-02T14:49:34

@skliper skliper added the bug Something isn't working label Sep 25, 2019
@skliper
Copy link
Contributor Author

skliper commented Sep 25, 2019

Trac comment by jphickey on 2015-03-13 15:38:50:

Pushed branch "trac-15-cfe_const_api", commit [changeset:8c0f96b] to address this

@skliper
Copy link
Contributor Author

skliper commented Sep 25, 2019

Trac comment by jphickey on 2015-03-13 16:11:40:

DEPENDENCY NOTE: This change set depends on elements from the #4 nd #9 fixes being already in place. It could theoretically be rebased without them if necessary, but then that would produce a merge conflict when putting them back together again.

Therefore the commit for this change set is currently based on an intermediate merge that has both trac-1 and trac-6 branches already included in it. (It is not based on "master")

@skliper
Copy link
Contributor Author

skliper commented Sep 25, 2019

Trac comment by sduran on 2015-03-19 17:23:08:

Change looks ok.

@skliper
Copy link
Contributor Author

skliper commented Sep 25, 2019

Trac comment by jphickey on 2015-04-06 12:05:27:

This is ready for review/merge

@skliper
Copy link
Contributor Author

skliper commented Sep 25, 2019

Trac comment by glimes on 2015-04-07 12:38:51:

Tested changeset [changeset:8c0f96b] as part of ic-2015-03-10 merge.

@skliper
Copy link
Contributor Author

skliper commented Sep 25, 2019

Trac comment by glimes on 2015-04-07 14:43:55:

I recommend accepting this changeset.

@skliper
Copy link
Contributor Author

skliper commented Sep 25, 2019

Trac comment by acudmore on 2015-04-07 14:44:15:

Concur

@skliper
Copy link
Contributor Author

skliper commented Sep 25, 2019

Trac comment by glimes on 2015-04-13 13:50:15:

Part of integration candidate 2015-03-10,
committed to PSP Development branch on 2015-04-10
as part of merge [changeset:945cb59].

@skliper
Copy link
Contributor Author

skliper commented Sep 25, 2019

Trac comment by glimes on 2016-01-11 10:42:10:

Mark for PSP 1.3 per email from sstrege

@skliper
Copy link
Contributor Author

skliper commented Sep 25, 2019

Trac comment by jhageman on 2019-04-02 14:49:34:

Milestone renamed

@skliper skliper closed this as completed Sep 25, 2019
@skliper skliper removed their assignment Sep 26, 2019
This was referenced Sep 26, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
1.3.0
Development

No branches or pull requests
1 participant
@skliper