Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could simplify by just managing tables periodically vs by registering for command (unique approach across common apps) #45

Open
3 tasks done
skliper opened this issue Aug 19, 2022 · 0 comments

Comments

@skliper
Copy link
Contributor

skliper commented Aug 19, 2022

Checklist (Please check before submitting)

  • I reviewed the Contributing Guide.
  • I reviewed the README file to see if the feature is in the major future work.
  • I performed a cursory search to see if the feature request is relevant, not redundant, nor in conflict with other tickets.

Is your feature request related to a problem? Please describe.
For the standard 10 apps, SC is the only one to use the CFE_TBL_NotifyByMessage API and manage tables on command.

SC/fsw/src/sc_app.c

Lines 606 to 612 in 68e2520

void SC_RegisterManageCmds(void)
{
int32 i;
/* Register for RTS info table manage request commands */
CFE_TBL_NotifyByMessage(SC_OperData.RtsInfoHandle, CFE_SB_ValueToMsgId(SC_CMD_MID), SC_MANAGE_TABLE_CC,
SC_TBL_ID_RTS_INFO);

SC/fsw/src/sc_cmds.c

Lines 683 to 685 in 68e2520

case SC_MANAGE_TABLE_CC:
SC_TableManageCmd(BufPtr);
break;

SC/fsw/src/sc_cmds.c

Lines 721 to 731 in 68e2520

void SC_TableManageCmd(const CFE_SB_Buffer_t *BufPtr)
{
int32 ArrayIndex;
int32 TableID = (int32)((CFE_TBL_NotifyCmd_t *)BufPtr)->Payload.Parameter;
/* Manage selected table as appropriate for each table type */
if ((TableID >= SC_TBL_ID_ATS_0) && (TableID < (SC_TBL_ID_ATS_0 + SC_NUMBER_OF_ATS)))
{
ArrayIndex = TableID - SC_TBL_ID_ATS_0;
SC_ManageAtsTable(ArrayIndex);
}

Describe the solution you'd like
Could instead just periodically manage all the tables (like all the rest).

Describe alternatives you've considered
None

Additional context
None

Requester Info
Jacob Hageman - NASA/GSFC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant