You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
To reach this would require that the code is built with a config where CFE_PLATFORM_EVS_MAX_EVENT_FILTERS (from platform config, defaults to 8) is less than CFE_SB_MAX_CFG_FILE_EVENTS_TO_FILTER (hardcoded to 8).
To Reproduce
Build code with default config and run coverage report.
Expected behavior
Code could be cleaned up to not have unreachable lines in any config, or at least convert the check such that it can be evaluated at compile time (if CFE_PLATFORM_EVS_MAX_EVENT_FILTERS >= CFE_SB_MAX_CFG_FILE_EVENTS_TO_FILTER then the code becomes unreachable).
System observed on:
Ubuntu
Additional context
Somewhat related to #1468, if this is fixed hopefully it would get both of these
Reporter Info
Joseph Hickey, Vantage Systems, Inc.
The text was updated successfully, but these errors were encountered:
Describe the bug
The following conditional is never reachable with the default config:
cFE/modules/sb/fsw/src/cfe_sb_task.c
Lines 192 to 195 in 2afdbc1
To reach this would require that the code is built with a config where
CFE_PLATFORM_EVS_MAX_EVENT_FILTERS
(from platform config, defaults to 8) is less thanCFE_SB_MAX_CFG_FILE_EVENTS_TO_FILTER
(hardcoded to 8).To Reproduce
Build code with default config and run coverage report.
Expected behavior
Code could be cleaned up to not have unreachable lines in any config, or at least convert the check such that it can be evaluated at compile time (if
CFE_PLATFORM_EVS_MAX_EVENT_FILTERS
>=CFE_SB_MAX_CFG_FILE_EVENTS_TO_FILTER
then the code becomes unreachable).System observed on:
Ubuntu
Additional context
Somewhat related to #1468, if this is fixed hopefully it would get both of these
Reporter Info
Joseph Hickey, Vantage Systems, Inc.
The text was updated successfully, but these errors were encountered: