Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functional tests for cFE Get Table Information APIs #1688

Closed
zanzaben opened this issue Jul 20, 2021 · 4 comments · Fixed by #1734 or #1772
Closed

Add functional tests for cFE Get Table Information APIs #1688

zanzaben opened this issue Jul 20, 2021 · 4 comments · Fixed by #1734 or #1772
Assignees
Milestone

Comments

@zanzaben
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Need open source functional tests for certifiability

Describe the solution you'd like
Add functional tests for cFE Get Table Information APIs
CFE_TBL_GetStatus - Obtain current status of pending actions for a table.
CFE_TBL_GetInfo - Obtain characteristics/information of/about a specified table.
CFE_TBL_NotifyByMessage - Instruct cFE Table Services to notify Application via message when table requires management.

Describe alternatives you've considered
N/A

Additional context
N/A

Requester Info
Alex Campbell GSFC

@skliper skliper added this to the 7.0.0 milestone Jul 22, 2021
@nmullane
Copy link
Contributor

I'll start working on this

@nmullane
Copy link
Contributor

Do I need to test "complex" behavior of these functions

Currently, I'm just testing error conditions and the most basic successful calls of these functions. Should I test more complicated behavior of these functions?

Are there things in the following lists that I should be testing?

CFE_TBL_GetStatus:

  • Test that pending update, validation statuses are returned at the correct time
    • Is there a way to trigger these states?

CFE_TBL_GetInfo:

  • test number of users increments after the table is shared
  • test crc is valid
  • test last file loaded is correct after loading a file
  • test table loaded once updates after loading
  • test file created time makes sense

CFE_TBL_NotifyByMessage:

  • Test messages are actually sent with correct message id, cc, parameter

@skliper
Copy link
Contributor

skliper commented Jul 30, 2021

This first round through the priority is error conditions and whatever is easy to functionally check (it's more important to get the basic testing in for all the APIs, than a really high fidelity test for just a subset). It is helpful to note in the test what you currently aren't covering and should be added eventually.

@skliper
Copy link
Contributor

skliper commented Jul 30, 2021

Actually, instead of noting in the test the preference would be to add an issue that details the suggested additions. Easier to track that way!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants