Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid generating module-specific msgid files if project has provided an all-inclusive "cfe_msgids.h" file #2405

Open
jphickey opened this issue Jul 18, 2023 · 1 comment
Milestone

Comments

@jphickey
Copy link
Contributor

Is your feature request related to a problem? Please describe.
As part of the effort to better compartmentalize the various CFE subcomponents, we are working toward having each module manage its own individual header files.

During this migration, this presents some confusion for a configuration that already has an all-inclusive cfe_msgids.h - as these individual msgid headers will still be generated (with default values) even though they are not used.

Describe the solution you'd like
To reduce confusion -- if the user has a cfe_msgids.h file, then do not generate the individualized msgid files.

Describe alternatives you've considered
The other option would be to revert the focused msgid.h file and go back to having cfe_msgids.h being the only msgid header for CFE.

Additional context
There is a possibility that a user has overridden the cfe_msgids.h but in a way that still #includes some (but perhaps not all) of the focused msgid headers. This proposal would break such a config.... so if that is a real possibility, this might not be a good idea.

Requester Info
Joseph Hickey, Vantage Systems, Inc.

@skliper
Copy link
Contributor

skliper commented Jul 18, 2023

Could just have a cmake flag to turn it off from the user point of view if there's a legitimate use case for users including subcomponent msgid headers from cfe_msgids.h. I can't think of a real need though.... if you want to replace just some, they could just do it at the subcomponent level and use the default cfe_msgids.h.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants