Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

count-sem-test, bin-sem-test intermittently fail on POSIX as non-root user #1445

Open
ahatstat opened this issue Jan 31, 2024 · 3 comments
Open

count-sem-test, bin-sem-test intermittently fail on POSIX as non-root user #1445

ahatstat opened this issue Jan 31, 2024 · 3 comments

Comments

@ahatstat
Copy link
Contributor

ahatstat commented Jan 31, 2024 •
edited
Loading

Describe the bug
count-sem-test and bin-sem-test unit tests fail intermittently on POSIX systems when running the tests as a non-elevated user when OSAL_CONFIG_DEBUG_PERMISSIVE_MODE is True. Both tests fail for the same reason. The tests spawn multiple tasks with different priority and assert that the highest priority task executes before the others. When running the tests on Linux as a regular user it is not possible to set the thread priority. When OSAL_CONFIG_DEBUG_PERMISSIVE_MODE set to True any attempt to set the thread priority is ignored. In this mode there is no guarantee which task executes first causing the tests to fail intermittently.

To Reproduce
Build OSAL with tests for generic-linux on any Linux PC as described in the quick start

mkdir build_osal_test
cd build_osal_test
cmake -DENABLE_UNIT_TESTS=true -DOSAL_SYSTEM_BSPTYPE=generic-linux -DOSAL_CONFIG_DEBUG_PERMISSIVE_MODE=TRUE ..
make
make test

Run bin-sem-test or count-sem-test in a loop as a regular user. It will eventually fail. See the test outputs below for the failing case.
Note that running the tests in a loop as root does not seem to fail.

Expected behavior
The tests should always pass.

Code snips
bin-sem-test.c

    /* Start 3 child tasks, give and confirm highest priority task increments, flush and confirm all three */
    UtAssert_INT32_EQ(
        OS_TaskCreate(&task_id[0], "Task_0", Test_BinSem_Task0, NULL, TASK_STACK_SIZE, OSAL_PRIORITY_C(100), 0),
        OS_SUCCESS);
    UtAssert_INT32_EQ(
        OS_TaskCreate(&task_id[1], "Task_1", Test_BinSem_Task1, NULL, TASK_STACK_SIZE, OSAL_PRIORITY_C(200), 0),
        OS_SUCCESS);
    UtAssert_INT32_EQ(
        OS_TaskCreate(&task_id[2], "Task_2", Test_BinSem_Task2, NULL, TASK_STACK_SIZE, OSAL_PRIORITY_C(250), 0),
        OS_SUCCESS);
    OS_TaskDelay(100);
    UtAssert_UINT32_EQ(task_counter[0] + task_counter[1] + task_counter[2], 0);
    UtAssert_INT32_EQ(OS_BinSemGive(sem_id[0]), OS_SUCCESS);
    OS_TaskDelay(100);
    // Any of the following tests can fail
    UtAssert_UINT32_EQ(task_counter[0], 1);
    UtAssert_UINT32_EQ(task_counter[1] + task_counter[2], 0);**
    UtAssert_INT32_EQ(OS_BinSemFlush(sem_id[0]), OS_SUCCESS);
    OS_TaskDelay(100);
    UtAssert_UINT32_EQ(task_counter[0], 2);
    UtAssert_UINT32_EQ(task_counter[1], 1);
    UtAssert_UINT32_EQ(task_counter[2], 1);

count-sem-test.c

    /* Start 3 child tasks, give and confirm highest priority task increments, flush and confirm all three */
    UtAssert_INT32_EQ(
        OS_TaskCreate(&task_id[0], "Task_0", Test_CountSem_Task0, NULL, TASK_STACK_SIZE, OSAL_PRIORITY_C(100), 0),
        OS_SUCCESS);
    UtAssert_INT32_EQ(
        OS_TaskCreate(&task_id[1], "Task_1", Test_CountSem_Task1, NULL, TASK_STACK_SIZE, OSAL_PRIORITY_C(200), 0),
        OS_SUCCESS);
    UtAssert_INT32_EQ(
        OS_TaskCreate(&task_id[2], "Task_2", Test_CountSem_Task2, NULL, TASK_STACK_SIZE, OSAL_PRIORITY_C(250), 0),
        OS_SUCCESS);
    OS_TaskDelay(100);
    UtAssert_UINT32_EQ(task_counter[0] + task_counter[1] + task_counter[2], 0);
    UtAssert_INT32_EQ(OS_CountSemGive(sem_id[0]), OS_SUCCESS);
    OS_TaskDelay(100);
    // These tests can fail
    UtAssert_UINT32_EQ(task_counter[0], 1);
    UtAssert_UINT32_EQ(task_counter[1] + task_counter[2], 0);

System observed on:

  • PC
  • OS: Ubuntu 22.04
  • Versions: [OSAL Equuleus-rc1+dev2] (fed9ead)

Additional context

Reporter Info
Andrew Hatstat, Geost
@ahatstat
Copy link
Contributor Author

Here is the output of count-sem-test when it fails

[BEGIN] UNIT TEST

[BEGIN] 01 SETUP
OS_Posix_GetSchedulerParams():202:Policy 1: available, min-max: 1-99
OS_Posix_GetSchedulerParams():202:Policy 2: available, min-max: 1-99
OS_Posix_TaskAPI_Impl_Init():388:Selected policy 2 for RT tasks, root task = 99
OS_Posix_TaskAPI_Impl_Init():405:Could not setschedparam in main thread: Operation not permitted (1)
[  END] No test cases

[BEGIN] 01 Test_CountSem
[ PASS] 01.001 count-sem-test.c:86 - OS_CountSemGetInfo(OS_OBJECT_ID_UNDEFINED, &sem_prop) (-16) == OS_ERR_INVALID_ID (-16)
[ PASS] 01.002 count-sem-test.c:87 - OS_CountSemGive(OS_OBJECT_ID_UNDEFINED) (-16) == OS_ERR_INVALID_ID (-16)
[ PASS] 01.003 count-sem-test.c:88 - OS_CountSemTake(OS_OBJECT_ID_UNDEFINED) (-16) == OS_ERR_INVALID_ID (-16)
[ PASS] 01.004 count-sem-test.c:89 - OS_CountSemTimedWait(OS_OBJECT_ID_UNDEFINED, 0) (-16) == OS_ERR_INVALID_ID (-16)
[ PASS] 01.005 count-sem-test.c:90 - OS_CountSemDelete(OS_OBJECT_ID_UNDEFINED) (-16) == OS_ERR_INVALID_ID (-16)
[ PASS] 01.006 count-sem-test.c:93 - OS_CountSemCreate(NULL, "Test_Sem", 0, 0) (-2) == OS_INVALID_POINTER (-2)
[ PASS] 01.007 count-sem-test.c:94 - OS_CountSemCreate(&sem_id[0], NULL, 0, 0) (-2) == OS_INVALID_POINTER (-2)
[ PASS] 01.008 count-sem-test.c:95 - OS_CountSemGetInfo(sem_id[0], NULL) (-2) == OS_INVALID_POINTER (-2)
[ PASS] 01.009 count-sem-test.c:96 - OS_CountSemGetIdByName(NULL, "Test_Sem") (-2) == OS_INVALID_POINTER (-2)
[ PASS] 01.010 count-sem-test.c:97 - OS_CountSemGetIdByName(&sem_id[0], NULL) (-2) == OS_INVALID_POINTER (-2)
[ PASS] 01.011 count-sem-test.c:101 - OS_CountSemCreate(&sem_id[0], long_name, 0, 0) (-13) == OS_ERR_NAME_TOO_LONG (-13)
[ PASS] 01.012 count-sem-test.c:102 - OS_CountSemGetIdByName(&sem_id[0], long_name) (-13) == OS_ERR_NAME_TOO_LONG (-13)
[ PASS] 01.013 count-sem-test.c:105 - OS_CountSemCreate(&sem_id[0], "Test_Sem", 0, 0) (0) == OS_SUCCESS (0)
[ PASS] 01.014 count-sem-test.c:106 - OS_CountSemCreate(&sem_id[1], "Test_Sem", 0, 0) (-15) == OS_ERR_NAME_TAKEN (-15)

**BUG** OS_CountSemCreate():90:check '(sem_id) != NULL' FAILED --> OS_INVALID_POINTER


**BUG** OS_CountSemCreate():91:check '(sem_name) != NULL' FAILED --> OS_INVALID_POINTER


**BUG** OS_CountSemGetInfo():230:check '(count_prop) != NULL' FAILED --> OS_INVALID_POINTER


**BUG** OS_CountSemGetIdByName():209:check '(sem_id) != NULL' FAILED --> OS_INVALID_POINTER


**BUG** OS_CountSemGetIdByName():210:check '(sem_name) != NULL' FAILED --> OS_INVALID_POINTER

[ PASS] 01.015 count-sem-test.c:109 - OS_CountSemCreate(&sem_id[1], "Test_Sem_Nonzero", 2, 0) (0) == OS_SUCCESS (0)
[ PASS] 01.016 count-sem-test.c:117 - OS_CountSemGetInfo(sem_id[0], &sem_prop) (0) == OS_SUCCESS (0)
[ PASS] 01.017 count-sem-test.c:118 - sem_prop.value (0) == 0 (0)
[ PASS] 01.018 count-sem-test.c:119 - OS_CountSemGetInfo(sem_id[1], &sem_prop) (0) == OS_SUCCESS (0)
[ PASS] 01.019 count-sem-test.c:120 - sem_prop.value (2) == 2 (2)
[ PASS] 01.020 count-sem-test.c:124 - OS_CountSemTimedWait(sem_id[0], 0) (-7) == OS_SEM_TIMEOUT (-7)
[ PASS] 01.021 count-sem-test.c:125 - OS_CountSemTimedWait(sem_id[0], 1) (-7) == OS_SEM_TIMEOUT (-7)
[ PASS] 01.022 count-sem-test.c:128 - OS_CountSemGive(sem_id[0]) (0) == OS_SUCCESS (0)
[ PASS] 01.023 count-sem-test.c:129 - OS_CountSemGive(sem_id[0]) (0) == OS_SUCCESS (0)
[ PASS] 01.024 count-sem-test.c:130 - OS_CountSemGive(sem_id[0]) (0) == OS_SUCCESS (0)
[ PASS] 01.025 count-sem-test.c:133 - OS_CountSemGetInfo(sem_id[0], &sem_prop) (0) == OS_SUCCESS (0)
[ PASS] 01.026 count-sem-test.c:134 - sem_prop.value (3) == 3 (3)
[ PASS] 01.027 count-sem-test.c:136 - OS_CountSemTake(sem_id[0]) (0) == OS_SUCCESS (0)
[ PASS] 01.028 count-sem-test.c:137 - OS_CountSemTimedWait(sem_id[0], 0) (0) == OS_SUCCESS (0)
[ PASS] 01.029 count-sem-test.c:138 - OS_CountSemTimedWait(sem_id[0], 1) (0) == OS_SUCCESS (0)
[ PASS] 01.030 count-sem-test.c:139 - OS_CountSemTimedWait(sem_id[0], 0) (-7) == OS_SEM_TIMEOUT (-7)
[ PASS] 01.031 count-sem-test.c:142 - OS_CountSemTimedWait(sem_id[1], 1) (0) == OS_SUCCESS (0)
[ PASS] 01.032 count-sem-test.c:143 - OS_CountSemTimedWait(sem_id[1], 0) (0) == OS_SUCCESS (0)
[ PASS] 01.033 count-sem-test.c:148 - OS_CountSemGetInfo(sem_id[0], &sem_prop) (0) == OS_SUCCESS (0)
[ PASS] 01.034 count-sem-test.c:149 - sem_prop.value (0) == 0 (0)
[ PASS] 01.035 count-sem-test.c:150 - OS_CountSemGetInfo(sem_id[1], &sem_prop) (0) == OS_SUCCESS (0)
[ PASS] 01.036 count-sem-test.c:151 - sem_prop.value (0) == 0 (0)
[ PASS] 01.037 count-sem-test.c:160 - OS_TaskCreate(&task_id[0], "Task_0", Test_CountSem_Task0, NULL, TASK_STACK_SIZE, OSAL_PRIORITY_C(100), 0) (0) == OS_SUCCESS (0)
[ PASS] 01.038 count-sem-test.c:35 - OS_CountSemGetIdByName(&sem_id, "Test_Sem") (0) == OS_SUCCESS (0)
[ PASS] 01.039 count-sem-test.c:164 - OS_TaskDelete(task_id[0]) (0) == OS_SUCCESS (0)
[ PASS] 01.040 count-sem-test.c:165 - task_counter[0] (0) == 0 (0)
[ PASS] 01.041 count-sem-test.c:169 - OS_CountSemGetInfo(sem_id[0], &sem_prop) (0) == OS_SUCCESS (0)
[ PASS] 01.042 count-sem-test.c:170 - sem_prop.value (0) == 0 (0)
[ PASS] 01.043 count-sem-test.c:178 - OS_TaskCreate(&task_id[0], "Task_0", Test_CountSem_Task0, NULL, TASK_STACK_SIZE, OSAL_PRIORITY_C(100), 0) (0) == OS_SUCCESS (0)
[ PASS] 01.044 count-sem-test.c:181 - OS_TaskCreate(&task_id[1], "Task_1", Test_CountSem_Task1, NULL, TASK_STACK_SIZE, OSAL_PRIORITY_C(200), 0) (0) == OS_SUCCESS (0)
[ PASS] 01.045 count-sem-test.c:184 - OS_TaskCreate(&task_id[2], "Task_2", Test_CountSem_Task2, NULL, TASK_STACK_SIZE, OSAL_PRIORITY_C(250), 0) (0) == OS_SUCCESS (0)
[ PASS] 01.046 count-sem-test.c:49 - OS_CountSemGetIdByName(&sem_id, "Test_Sem") (0) == OS_SUCCESS (0)
[ PASS] 01.047 count-sem-test.c:35 - OS_CountSemGetIdByName(&sem_id, "Test_Sem") (0) == OS_SUCCESS (0)
[ PASS] 01.048 count-sem-test.c:63 - OS_CountSemGetIdByName(&sem_id, "Test_Sem") (0) == OS_SUCCESS (0)
[ PASS] 01.049 count-sem-test.c:188 - task_counter[0] + task_counter[1] + task_counter[2] (0) == 0 (0)
[ PASS] 01.050 count-sem-test.c:189 - OS_CountSemGive(sem_id[0]) (0) == OS_SUCCESS (0)
[ PASS] 01.051 count-sem-test.c:53 - OS_CountSemTake(sem_id) (0) == OS_SUCCESS (0)
[ FAIL] 01.052 count-sem-test.c:191 - task_counter[0] (0) == 1 (1)
[ FAIL] 01.053 count-sem-test.c:192 - task_counter[1] + task_counter[2] (1) == 0 (0)
[ PASS] 01.054 count-sem-test.c:199 - OS_CountSemGive(sem_id[0]) (0) == OS_SUCCESS (0)
[ PASS] 01.055 count-sem-test.c:39 - OS_CountSemTake(sem_id) (0) == OS_SUCCESS (0)
[ PASS] 01.056 count-sem-test.c:201 - task_counter[0] + task_counter[1] + task_counter[2] (2) == test_val (2)
[ PASS] 01.057 count-sem-test.c:199 - OS_CountSemGive(sem_id[0]) (0) == OS_SUCCESS (0)
[ PASS] 01.058 count-sem-test.c:67 - OS_CountSemTimedWait(sem_id, 1000) (0) == OS_SUCCESS (0)
[ PASS] 01.059 count-sem-test.c:201 - task_counter[0] + task_counter[1] + task_counter[2] (3) == test_val (3)
[ PASS] 01.060 count-sem-test.c:199 - OS_CountSemGive(sem_id[0]) (0) == OS_SUCCESS (0)
[ PASS] 01.061 count-sem-test.c:53 - OS_CountSemTake(sem_id) (0) == OS_SUCCESS (0)
[ PASS] 01.062 count-sem-test.c:201 - task_counter[0] + task_counter[1] + task_counter[2] (4) == test_val (4)
[ PASS] 01.063 count-sem-test.c:199 - OS_CountSemGive(sem_id[0]) (0) == OS_SUCCESS (0)
[ PASS] 01.064 count-sem-test.c:39 - OS_CountSemTake(sem_id) (0) == OS_SUCCESS (0)
[ PASS] 01.065 count-sem-test.c:201 - task_counter[0] + task_counter[1] + task_counter[2] (5) == test_val (5)
[ PASS] 01.066 count-sem-test.c:199 - OS_CountSemGive(sem_id[0]) (0) == OS_SUCCESS (0)
[ PASS] 01.067 count-sem-test.c:67 - OS_CountSemTimedWait(sem_id, 1000) (0) == OS_SUCCESS (0)
[ PASS] 01.068 count-sem-test.c:201 - task_counter[0] + task_counter[1] + task_counter[2] (6) == test_val (6)
[ PASS] 01.069 count-sem-test.c:199 - OS_CountSemGive(sem_id[0]) (0) == OS_SUCCESS (0)
[ PASS] 01.070 count-sem-test.c:53 - OS_CountSemTake(sem_id) (0) == OS_SUCCESS (0)
[ PASS] 01.071 count-sem-test.c:201 - task_counter[0] + task_counter[1] + task_counter[2] (7) == test_val (7)
[ PASS] 01.072 count-sem-test.c:199 - OS_CountSemGive(sem_id[0]) (0) == OS_SUCCESS (0)
[ PASS] 01.073 count-sem-test.c:39 - OS_CountSemTake(sem_id) (0) == OS_SUCCESS (0)
[ PASS] 01.074 count-sem-test.c:201 - task_counter[0] + task_counter[1] + task_counter[2] (8) == test_val (8)
[ PASS] 01.075 count-sem-test.c:199 - OS_CountSemGive(sem_id[0]) (0) == OS_SUCCESS (0)
[ PASS] 01.076 count-sem-test.c:67 - OS_CountSemTimedWait(sem_id, 1000) (0) == OS_SUCCESS (0)
[ PASS] 01.077 count-sem-test.c:201 - task_counter[0] + task_counter[1] + task_counter[2] (9) == test_val (9)
[ PASS] 01.078 count-sem-test.c:205 - OS_CountSemGive(sem_id[0]) (0) == OS_SUCCESS (0)
[ PASS] 01.079 count-sem-test.c:207 - task_counter[0] + task_counter[1] + task_counter[2] (9) == test_val (9)
[ PASS] 01.080 count-sem-test.c:210 - OS_CountSemDelete(sem_id[0]) (0) == OS_SUCCESS (0)
[ PASS] 01.081 count-sem-test.c:211 - OS_CountSemDelete(sem_id[1]) (0) == OS_SUCCESS (0)
[ INFO]                        ABORT::0     WARN::0     FLOW::0     DEBUG::0     N/A::0
[  END] 01 Test_CountSem        TOTAL::81    PASS::79    FAIL::2     MIR::0     TSF::0     TTF::0

[BEGIN] 02 Cleanup
[  END] No test cases
COMPLETE: 1 tests Segment(s) executed

@ahatstat
Copy link
Contributor Author

here is the output of bin-sem-test when it fails

[BEGIN] 01 Test_BinSem
[ PASS] 01.001 bin-sem-test.c:86 - OS_BinSemGetInfo(OS_OBJECT_ID_UNDEFINED, &sem_prop) (-16) == OS_ERR_INVALID_ID (-16)
[ PASS] 01.002 bin-sem-test.c:87 - OS_BinSemFlush(OS_OBJECT_ID_UNDEFINED) (-16) == OS_ERR_INVALID_ID (-16)
[ PASS] 01.003 bin-sem-test.c:88 - OS_BinSemGive(OS_OBJECT_ID_UNDEFINED) (-16) == OS_ERR_INVALID_ID (-16)
[ PASS] 01.004 bin-sem-test.c:89 - OS_BinSemTake(OS_OBJECT_ID_UNDEFINED) (-16) == OS_ERR_INVALID_ID (-16)
[ PASS] 01.005 bin-sem-test.c:90 - OS_BinSemTimedWait(OS_OBJECT_ID_UNDEFINED, 0) (-16) == OS_ERR_INVALID_ID (-16)
[ PASS] 01.006 bin-sem-test.c:91 - OS_BinSemDelete(OS_OBJECT_ID_UNDEFINED) (-16) == OS_ERR_INVALID_ID (-16)
[ PASS] 01.007 bin-sem-test.c:94 - OS_BinSemCreate(NULL, "Test_Sem", 0, 0) (-2) == OS_INVALID_POINTER (-2)
[ PASS] 01.008 bin-sem-test.c:95 - OS_BinSemCreate(&sem_id[0], NULL, 0, 0) (-2) == OS_INVALID_POINTER (-2)
[ PASS] 01.009 bin-sem-test.c:96 - OS_BinSemGetInfo(sem_id[0], NULL) (-2) == OS_INVALID_POINTER (-2)
[ PASS] 01.010 bin-sem-test.c:97 - OS_BinSemGetIdByName(NULL, "Test_Sem") (-2) == OS_INVALID_POINTER (-2)

**BUG** OS_BinSemCreate():98:check '(sem_id) != NULL' FAILED --> OS_INVALID_POINTER


**BUG** OS_BinSemCreate():99:check '(sem_name) != NULL' FAILED --> OS_INVALID_POINTER


**BUG** OS_BinSemGetInfo():259:check '(bin_prop) != NULL' FAILED --> OS_INVALID_POINTER


**BUG** OS_BinSemGetIdByName():238:check '(sem_id) != NULL' FAILED --> OS_INVALID_POINTER

[ PASS] 01.011 bin-sem-test.c:98 - OS_BinSemGetIdByName(&sem_id[0], NULL) (-2) == OS_INVALID_POINTER (-2)

**BUG** OS_BinSemGetIdByName():239:check '(sem_name) != NULL' FAILED --> OS_INVALID_POINTER

[ PASS] 01.012 bin-sem-test.c:102 - OS_BinSemCreate(&sem_id[0], long_name, 0, 0) (-13) == OS_ERR_NAME_TOO_LONG (-13)
[ PASS] 01.013 bin-sem-test.c:103 - OS_BinSemGetIdByName(&sem_id[0], long_name) (-13) == OS_ERR_NAME_TOO_LONG (-13)
[ PASS] 01.014 bin-sem-test.c:106 - OS_BinSemCreate(&sem_id[0], "Test_Sem", 0, 0) (0) == OS_SUCCESS (0)
[ PASS] 01.015 bin-sem-test.c:107 - OS_BinSemCreate(&sem_id[1], "Test_Sem", 0, 0) (-15) == OS_ERR_NAME_TAKEN (-15)
[ PASS] 01.016 bin-sem-test.c:110 - OS_BinSemCreate(&sem_id[1], "Test_Sem_Nonzero", 1, 0) (0) == OS_SUCCESS (0)
[ PASS] 01.017 bin-sem-test.c:118 - OS_BinSemGetInfo(sem_id[0], &sem_prop) (0) == OS_SUCCESS (0)
[ PASS] 01.018 bin-sem-test.c:119 - sem_prop.value (0) == 0 (0)
[ PASS] 01.019 bin-sem-test.c:120 - OS_BinSemGetInfo(sem_id[1], &sem_prop) (0) == OS_SUCCESS (0)
[ PASS] 01.020 bin-sem-test.c:121 - sem_prop.value (1) == 1 (1)
[ PASS] 01.021 bin-sem-test.c:125 - OS_BinSemTimedWait(sem_id[0], 0) (-7) == OS_SEM_TIMEOUT (-7)
[ PASS] 01.022 bin-sem-test.c:126 - OS_BinSemTimedWait(sem_id[0], 1) (-7) == OS_SEM_TIMEOUT (-7)
[ PASS] 01.023 bin-sem-test.c:129 - OS_BinSemGive(sem_id[0]) (0) == OS_SUCCESS (0)
[ PASS] 01.024 bin-sem-test.c:131 - OS_BinSemTake(sem_id[0]) (0) == OS_SUCCESS (0)
[ PASS] 01.025 bin-sem-test.c:132 - OS_BinSemTimedWait(sem_id[0], 0) (-7) == OS_SEM_TIMEOUT (-7)
[ PASS] 01.026 bin-sem-test.c:135 - OS_BinSemGive(sem_id[0]) (0) == OS_SUCCESS (0)
[ PASS] 01.027 bin-sem-test.c:136 - OS_BinSemTimedWait(sem_id[0], 0) (0) == OS_SUCCESS (0)
[ PASS] 01.028 bin-sem-test.c:137 - OS_BinSemGive(sem_id[0]) (0) == OS_SUCCESS (0)
[ PASS] 01.029 bin-sem-test.c:138 - OS_BinSemTimedWait(sem_id[0], 1) (0) == OS_SUCCESS (0)
[ PASS] 01.030 bin-sem-test.c:141 - OS_BinSemTimedWait(sem_id[1], 0) (0) == OS_SUCCESS (0)
[ PASS] 01.031 bin-sem-test.c:146 - OS_BinSemGetInfo(sem_id[0], &sem_prop) (0) == OS_SUCCESS (0)
[ PASS] 01.032 bin-sem-test.c:147 - sem_prop.value (0) == 0 (0)
[ PASS] 01.033 bin-sem-test.c:148 - OS_BinSemGetInfo(sem_id[1], &sem_prop) (0) == OS_SUCCESS (0)
[ PASS] 01.034 bin-sem-test.c:149 - sem_prop.value (0) == 0 (0)
[ PASS] 01.035 bin-sem-test.c:158 - OS_TaskCreate(&task_id[0], "Task_0", Test_BinSem_Task0, NULL, TASK_STACK_SIZE, OSAL_PRIORITY_C(100), 0) (0) == OS_SUCCESS (0)
[ PASS] 01.036 bin-sem-test.c:35 - OS_BinSemGetIdByName(&sem_id, "Test_Sem") (0) == OS_SUCCESS (0)
[ PASS] 01.037 bin-sem-test.c:162 - OS_TaskDelete(task_id[0]) (0) == OS_SUCCESS (0)
[ PASS] 01.038 bin-sem-test.c:163 - task_counter[0] (0) == 0 (0)
[ PASS] 01.039 bin-sem-test.c:167 - OS_BinSemGetInfo(sem_id[0], &sem_prop) (0) == OS_SUCCESS (0)
[ PASS] 01.040 bin-sem-test.c:168 - sem_prop.value (0) == 0 (0)
[ PASS] 01.041 bin-sem-test.c:176 - OS_TaskCreate(&task_id[0], "Task_0", Test_BinSem_Task0, NULL, TASK_STACK_SIZE, OSAL_PRIORITY_C(100), 0) (0) == OS_SUCCESS (0)
[ PASS] 01.042 bin-sem-test.c:179 - OS_TaskCreate(&task_id[1], "Task_1", Test_BinSem_Task1, NULL, TASK_STACK_SIZE, OSAL_PRIORITY_C(200), 0) (0) == OS_SUCCESS (0)
[ PASS] 01.043 bin-sem-test.c:49 - OS_BinSemGetIdByName(&sem_id, "Test_Sem") (0) == OS_SUCCESS (0)
[ PASS] 01.044 bin-sem-test.c:182 - OS_TaskCreate(&task_id[2], "Task_2", Test_BinSem_Task2, NULL, TASK_STACK_SIZE, OSAL_PRIORITY_C(250), 0) (0) == OS_SUCCESS (0)
[ PASS] 01.045 bin-sem-test.c:35 - OS_BinSemGetIdByName(&sem_id, "Test_Sem") (0) == OS_SUCCESS (0)
[ PASS] 01.046 bin-sem-test.c:63 - OS_BinSemGetIdByName(&sem_id, "Test_Sem") (0) == OS_SUCCESS (0)
[ PASS] 01.047 bin-sem-test.c:186 - task_counter[0] + task_counter[1] + task_counter[2] (0) == 0 (0)
[ PASS] 01.048 bin-sem-test.c:187 - OS_BinSemGive(sem_id[0]) (0) == OS_SUCCESS (0)
[ PASS] 01.049 bin-sem-test.c:53 - OS_BinSemTake(sem_id) (0) == OS_SUCCESS (0)
[ FAIL] 01.050 bin-sem-test.c:189 - task_counter[0] (0) == 1 (1)
[ FAIL] 01.051 bin-sem-test.c:190 - task_counter[1] + task_counter[2] (1) == 0 (0)
[ PASS] 01.052 bin-sem-test.c:191 - OS_BinSemFlush(sem_id[0]) (0) == OS_SUCCESS (0)
[ PASS] 01.053 bin-sem-test.c:39 - OS_BinSemTake(sem_id) (0) == OS_SUCCESS (0)
[ PASS] 01.054 bin-sem-test.c:67 - OS_BinSemTimedWait(sem_id, 1000) (0) == OS_SUCCESS (0)
[ PASS] 01.055 bin-sem-test.c:53 - OS_BinSemTake(sem_id) (0) == OS_SUCCESS (0)
[ FAIL] 01.056 bin-sem-test.c:193 - task_counter[0] (1) == 2 (2)
[ FAIL] 01.057 bin-sem-test.c:194 - task_counter[1] (2) == 1 (1)
[ PASS] 01.058 bin-sem-test.c:195 - task_counter[2] (1) == 1 (1)
[ PASS] 01.059 bin-sem-test.c:202 - OS_BinSemGive(sem_id[0]) (0) == OS_SUCCESS (0)
[ PASS] 01.060 bin-sem-test.c:39 - OS_BinSemTake(sem_id) (0) == OS_SUCCESS (0)
[ PASS] 01.061 bin-sem-test.c:204 - task_counter[0] + task_counter[1] + task_counter[2] (5) == test_val (5)
[ PASS] 01.062 bin-sem-test.c:202 - OS_BinSemGive(sem_id[0]) (0) == OS_SUCCESS (0)
[ PASS] 01.063 bin-sem-test.c:67 - OS_BinSemTimedWait(sem_id, 1000) (0) == OS_SUCCESS (0)
[ PASS] 01.064 bin-sem-test.c:204 - task_counter[0] + task_counter[1] + task_counter[2] (6) == test_val (6)
[ PASS] 01.065 bin-sem-test.c:202 - OS_BinSemGive(sem_id[0]) (0) == OS_SUCCESS (0)
[ PASS] 01.066 bin-sem-test.c:53 - OS_BinSemTake(sem_id) (0) == OS_SUCCESS (0)
[ PASS] 01.067 bin-sem-test.c:204 - task_counter[0] + task_counter[1] + task_counter[2] (7) == test_val (7)
[ PASS] 01.068 bin-sem-test.c:202 - OS_BinSemGive(sem_id[0]) (0) == OS_SUCCESS (0)
[ PASS] 01.069 bin-sem-test.c:39 - OS_BinSemTake(sem_id) (0) == OS_SUCCESS (0)
[ PASS] 01.070 bin-sem-test.c:204 - task_counter[0] + task_counter[1] + task_counter[2] (8) == test_val (8)
[ PASS] 01.071 bin-sem-test.c:202 - OS_BinSemGive(sem_id[0]) (0) == OS_SUCCESS (0)
[ PASS] 01.072 bin-sem-test.c:67 - OS_BinSemTimedWait(sem_id, 1000) (0) == OS_SUCCESS (0)
[ PASS] 01.073 bin-sem-test.c:204 - task_counter[0] + task_counter[1] + task_counter[2] (9) == test_val (9)
[ PASS] 01.074 bin-sem-test.c:208 - OS_BinSemGive(sem_id[0]) (0) == OS_SUCCESS (0)
[ PASS] 01.075 bin-sem-test.c:210 - task_counter[0] + task_counter[1] + task_counter[2] (9) == test_val (9)
[ PASS] 01.076 bin-sem-test.c:213 - OS_BinSemDelete(sem_id[0]) (0) == OS_SUCCESS (0)
[ PASS] 01.077 bin-sem-test.c:214 - OS_BinSemDelete(sem_id[1]) (0) == OS_SUCCESS (0)
[ INFO]                        ABORT::0     WARN::0     FLOW::0     DEBUG::0     N/A::0
[  END] 01 Test_BinSem          TOTAL::77    PASS::73    FAIL::4     MIR::0     TSF::0     TTF::0

@skliper
Copy link
Contributor

skliper commented Jan 31, 2024

Looks like it's failing due to the non-root scheduling. Likely needs more relaxed asserts in the case where priorities aren't strictly enforced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ahatstat @skliper