Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Sass source maps with absolute paths in sources #7068

Closed
thatmattlove opened this issue Aug 30, 2021 · 0 comments
Closed

Fix Sass source maps with absolute paths in sources #7068

thatmattlove opened this issue Aug 30, 2021 · 0 comments
Assignees
Labels
type: housekeeping Changes to the application which do not directly impact the end user

Comments

@thatmattlove
Copy link
Contributor

Proposed Changes

Figure out how to use a relative path, or disable sourcemaps for Sass files altogether.

See:

Justification

As-is, the absolute path of the source file is included in Sass maps, for example:

{
  "version": 3,
  "sources": ["sass:/Users/ml/dev/netbox/netbox/project-static/styles/_cable_trace.scss"],
  "mappings": "...",
  "names": []
}

JavaScript sourcemaps, on the other hand, contain relative paths. For example:

{
  "version": 3,
  "sources": ["../src/select/api/apiSelect.ts"],
  "mappings": "...",
  "names": []
}
@thatmattlove thatmattlove added the type: housekeeping Changes to the application which do not directly impact the end user label Aug 30, 2021
@thatmattlove thatmattlove self-assigned this Aug 30, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: housekeeping Changes to the application which do not directly impact the end user
Projects
None yet
Development

No branches or pull requests

1 participant