Yolov3 #103
Merged
Yolov3 #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JsonSadler
suggested changes
Dec 20, 2020
libs/classifiers/classifier.py
Outdated
| object['face_label'] = classifier_result | ||
| else: | ||
| object['face_label'] = -1 | ||
| if object.get('face') is not None: |
There was a problem hiding this comment.
If you check for existence, please do it with if 'face' in object rather than using .get(), I THINK if someday having None as the value of the key 'face' will be meaningful, this breaks the code as it exists but returns None.
libs/detectors/x86/yolov3.py
Outdated
| print('model does not exist under: ', self.model_path, 'downloading from ', url) | ||
| wget.download(url, self.model_path) | ||
|
|
||
| self.nms_thesh = 0.5 |
There was a problem hiding this comment.
I think you meant nms_thresh, missed the r.
| score = float(pred[5].cpu) | ||
| if cls == 0: # person class index is '0' at coco dataset | ||
| bbox_dict = {"id": "1-" + str(i), | ||
| "bbox": [c1[1] / self.h, c1[0] / self.w, c2[1] / self.h, c2[0] / self.w], "score": score, |
There was a problem hiding this comment.
Is this float division? self.w and self.h are integers.
There was a problem hiding this comment.
c1 and c2 both are int. The division works for normalizing the bbox.
| ; using openpifpaf (openpifpaf detects both faces and pedestrians) | ||
| ImageSize = 1281,721,3 |
There was a problem hiding this comment.
Could we keep this resolution for OpenPifPaf in a comment?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding yolov3 detector.