Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new ECS vendor data that reports container id #2563

Closed
jsumners-nr opened this issue Sep 12, 2024 · 1 comment · Fixed by #2565
Closed

Add new ECS vendor data that reports container id #2563

jsumners-nr opened this issue Sep 12, 2024 · 1 comment · Fixed by #2565
Assignees
@jsumners-nr
Labels
points: 3 A few days

Comments

@jsumners-nr
Copy link
Contributor

  1. Update

    node-newrelic/lib/utilization/index.js

    Line 10 in 4b0b95c

    const VENDOR_METHODS = {
    to include a new "ecs" vendor.
  2. Duplicate

    node-newrelic/lib/utilization/docker-info.js

    Line 49 in 7ae4af4

    getEcsContainerId({ agent, callback, logger })
    into the new ECS vendor
  3. Make the ECS vendor return an object { ecs: { ecsDockerId: 'whatever-it-is' } }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsumners-nr jsumners-nr

Labels
points: 3 A few days
Projects
Node.js Engineering Board
Status: Done: Issues recently completed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Added utilization info for ECS jsumners-nr/node-newrelic
1 participant
@jsumners-nr