Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requalify GPL detection rule as "clue" or rework detection #3833

Open
pombredanne opened this issue Jun 27, 2024 · 3 comments
Open

Requalify GPL detection rule as "clue" or rework detection #3833

pombredanne opened this issue Jun 27, 2024 · 3 comments

Comments

@pombredanne
Copy link
Contributor

https://github.com/nexB/scancode-toolkit/blob/develop/src/licensedcode/data/rules/openssl-ssleay_gpl_mention_openssl.RULE is not a license notice:

Permission to use under GPL terms is granted.

This is present in OpenSSL like at https://github.com/openssl/openssl/blob/master/crypto/sha/asm/sha256-armv4.pl or BoringSSL and derivative like https://raw.githubusercontent.com/apple/swift-nio-ssl/7c381eb6083542b124a6c18fae742f55001dc2b5/Sources/CNIOBoringSSL/crypto/fipsmodule/bsaes-armv7-ios.ios.arm.S but should NOT be reported as a GPL at all as this is noise.

We could also just treat this as a false positive entirely, or report it as OpenSSL-licensed since this is always seen with the previous "cryptograms" match: https://github.com/nexB/scancode-toolkit/blob/develop/src/licensedcode/data/rules/openssl-ssleay_or_bsd-new_2.RULE

@pombredanne pombredanne changed the title Requalify GPL detection rule as "clue" Requalify GPL detection rule as "clue" or rework detection Jun 27, 2024
@pombredanne
Copy link
Contributor Author

@pombredanne
Copy link
Contributor Author

See also this rule https://github.com/nexB/scancode-toolkit/blob/develop/src/licensedcode/data/rules/openssl-ssleay_or_bsd-new_or_gpl-1.0-plus_or_gpl-2.0_1.RULE that needs some love too as there is no gpl-1.0-plus in it.

@armijnhemel
Copy link
Contributor

#3841 might be similar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants