Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete Backups #278

Closed
ghost opened this issue Feb 26, 2022 · 6 comments · Fixed by #290
Closed

Delete Backups #278

ghost opened this issue Feb 26, 2022 · 6 comments · Fixed by #290
Labels
2. developing Work in progress borg documentation Improvements or additions to documentation
Milestone

Comments

@ghost
Copy link

ghost commented Feb 26, 2022

Add the function to delete the backups that are no longer needed in the Nextcloud AIO interface.

@szaimen
Copy link
Collaborator

szaimen commented Feb 28, 2022

Hi, why do you need this functionality?

@szaimen szaimen added question Further information is requested needs info Not enough information provided enhancement New feature or request and removed needs info Not enough information provided question Further information is requested labels Feb 28, 2022
@ghost
Copy link
Author

ghost commented Feb 28, 2022

To free space and delete files completely

@szaimen
Copy link
Collaborator

szaimen commented Mar 1, 2022

Since borg is fortunately very efficient in storing files and we already prune the backup archives regularly, I disagree that this is a must have feature for the AIO interface. I'll add some docs how to do this manually though.

@szaimen szaimen added borg documentation Improvements or additions to documentation and removed enhancement New feature or request needs info Not enough information provided labels Mar 1, 2022
@szaimen szaimen added this to the next milestone Mar 1, 2022
@szaimen szaimen added the 2. developing Work in progress label Mar 1, 2022
@ghost
Copy link
Author

ghost commented Mar 1, 2022

I understand what you're thinking, but I think it's also a security issue. In order to delete backups remotely you would have to have access to the server via SSH and open port 30 just so that backups can be deleted. I think this is a major security gap that could be avoided by implementing it in the AIO interface.

The other question would be why not add this feature?

@szaimen
Copy link
Collaborator

szaimen commented Mar 1, 2022

I understand what you're thinking, but I think it's also a security issue. In order to delete backups remotely you would have to have access to the server via SSH and open port 30 just so that backups can be deleted. I think this is a major security gap that could be avoided by implementing it in the AIO interface.

You must have had some SSH access (or direct access) to the server in the first place in order to be able to install AIO so you can still go that way.

Honestly I simply don't want to clutter the interface with that. Backups should simply not be deleted manually, imo. (As it would then e.g. also be possible that you delete all backups or the false ones, etc.)

For you to understand: I now run borg backups since a year or so on my personal server and I never needed the option to delete an archive manually since borg it is very efficient and the retention policy is in place as said before.

@ghost
Copy link
Author

ghost commented Mar 1, 2022

I would be more happy about the function, but then adding it to the documentation is very helpful.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2. developing Work in progress borg documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant