Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2573 breaks account change #2610

Closed
AndyScherzinger opened this issue May 23, 2018 · 5 comments
Closed

#2573 breaks account change #2610

AndyScherzinger opened this issue May 23, 2018 · 5 comments

Comments

@AndyScherzinger
Copy link
Member

the account switch isn't working anymore at all on the PR/branch #2573

Simply try to switch the account (2 accounts on 2 different servers).
If you remove the launch singleTop flag it works again for the user list in the drawer but still doesn't work at all for the avatar clicks in the drawer header. So something is really broken here.

Good thing, this doesn't happen on the master branch, or trashbin branch thus it must have been introduced via #2573

@tobiasKaminsky
Copy link
Member

I'll give it a try now.

@AndyScherzinger
Copy link
Member Author

Awesome! ❤️

@tobiasKaminsky
Copy link
Member

If you remove the launch singleTop flag it works again for the user list in the drawer but still doesn't work at all for the avatar clicks in the drawer header. So something is really broken here.

This is fixed with my latest commit.

With "singleTop" it is not working, but I'll debug it further.

@tobiasKaminsky
Copy link
Member

Now this is also working.
@AndyScherzinger please test and then we can close this 🎉

@AndyScherzinger
Copy link
Member Author

Works like a charm 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants